From: "George G. Davis" <george_davis@mentor.com>
To: shuah <shuah@kernel.org>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
Eugeniu Rosca <roscaeugeniu@gmail.com>,
Jerry Hoemann <jerry.hoemann@hpe.com>,
Colin Ian King <colin.king@canonical.com>,
<linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] selftests: watchdog: Add command line option to show watchdog_info
Date: Mon, 16 Sep 2019 12:15:41 -0400 [thread overview]
Message-ID: <20190916161541.GB19227@mam-gdavis-lt> (raw)
In-Reply-To: <24cc0dde-6df3-3ea2-3e1d-0bc166bb48ac@kernel.org>
Hello Shuah,
On Mon, Sep 16, 2019 at 10:05:17AM -0600, shuah wrote:
> On 9/16/19 7:57 AM, Eugeniu Rosca wrote:
> >Hi Shuah,
> >CC George
> >
> >On Mon, Sep 16, 2019 at 07:26:41AM -0600, shuah wrote:
> >[..]
> >>> case 'f':
> >>> /* Handled above */
> >>> break;
> >>>+ case 'i':
> >>>+ /*
> >>>+ * watchdog_info was obtained as part of file open
> >>>+ * validation. So we just show it here.
> >>>+ */
> >>>+ oneshot = 1;
> >>>+ printf("watchdog_info:\n");
> >>>+ printf(" identity:\t\t%s\n", info.identity);
> >>>+ printf(" firmware_version:\t%u\n",
> >>>+ info.firmware_version);
> >>>+ printf(" options:\t\t%08x\n", info.options);
> >>>+ break;
> >>> default:
> >>> usage(argv[0]);
> >>>
> >>
> >>I would like to see these combined. Please don't add another argument.
> >>Combine patch and 1&2.
> >
> >With all my appreciation for your comment, why do you think it is better
> >to get rid of the new argument? I don't think it is user-friendly to
> >always report the watchdog_info to the user. Just look at outputs [1-2]
> >and imagine that the watchdog_info part would pop up unconditionally.
> >It looks too busy to me.
>
> Yes it does look busy. I am okay with adding a second options
> based on what you both said.
>
> I don't like the commit log.
Agreed, I didn't like it either - it was rather a draft.
>
> Unfortunately this thread no longer contains the commit log.
>
> I would like to see the commit log without any references to side
> effects. It make it rather confusing.
>
> "A side of affect of commit "selftests: watchdog: Add optional file
> argument" is that arbitrary files may be opened for watchdog testing, e.g.
> /dev/null. To prevent watchdog-test from operating on non-watchdog device
> files, commit "selftests: watchdog: Validate optional file argument" was
> added to validate that a file is indeed a watchdog device via an
> ioctl(WDIOC_GETSUPPORT) call. Since the watchdog_info is available as a
> result of the ioctl(WDIOC_GETSUPPORT) call, add a command line option to
> show the watchdog_info."
>
> I would drop all references to that.
How about the following commit message for the squash commit for [1] and [2]?:
"
selftests: watchdog: Validate optional file argument
As reported by Eugeniu Rosca, a side of affect of commit c3f2490d6e92
("selftests: watchdog: Add optional file argument") is that arbitrary files
may be opened for watchdog testing, e.g.
./watchdog-test -f /dev/zero
Watchdog Ticking Away!
To prevent watchdog-test from operating on non-watchdog device files,
validate that a file is indeed a watchdog device via an
ioctl(WDIOC_GETSUPPORT) call.
While we're at it, since the watchdog_info is available as a result of the
ioctl(WDIOC_GETSUPPORT) call, add a command line option to optionally show
the watchdog_info.
"
Thanks!
>
> thanks,
> -- Shuah
--
Regards,
George
next prev parent reply other threads:[~2019-09-16 16:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 8:58 [PATCH 1/2] selftests: watchdog: Validate optional file argument Eugeniu Rosca
2019-09-07 8:58 ` [PATCH 2/2] selftests: watchdog: Add command line option to show watchdog_info Eugeniu Rosca
2019-09-16 13:26 ` shuah
2019-09-16 13:55 ` George G. Davis
2019-09-16 13:57 ` Eugeniu Rosca
2019-09-16 16:05 ` shuah
2019-09-16 16:15 ` George G. Davis [this message]
2019-09-17 18:53 ` Eugeniu Rosca
2019-09-16 12:08 ` [PATCH 1/2] selftests: watchdog: Validate optional file argument Eugeniu Rosca
2019-09-16 13:29 ` shuah
2019-09-17 18:55 ` Eugeniu Rosca
2019-09-16 13:25 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916161541.GB19227@mam-gdavis-lt \
--to=george_davis@mentor.com \
--cc=colin.king@canonical.com \
--cc=erosca@de.adit-jv.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=roscaeugeniu@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).