From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A9CC4360C for ; Fri, 27 Sep 2019 13:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F3F820872 for ; Fri, 27 Sep 2019 13:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727557AbfI0Nwt (ORCPT ); Fri, 27 Sep 2019 09:52:49 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:60697 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbfI0Nwt (ORCPT ); Fri, 27 Sep 2019 09:52:49 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id A9E9C804EA; Fri, 27 Sep 2019 15:52:31 +0200 (CEST) Date: Fri, 27 Sep 2019 15:52:36 +0200 From: Pavel Machek To: Ingo Molnar Cc: Linus Torvalds , Brendan Higgins , Shuah Khan , Mark Brown , Jarkko Sakkinen , Anders Roxell , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List Subject: Re: [GIT PULL] Kselftest update for Linux 5.4-rc1 Message-ID: <20190927135236.GA3557@bug> References: <20190922112555.GB122003@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190922112555.GB122003@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hi! > > I think I'm "special". > > > > There was some other similar change a few years ago, which I > > absolutely hated because of how it broke autocomplete for me. Very few > > other people seemed to react to it. > > FWIW, I am obsessively sensitive to autocomplete and overall source code > file hieararchy and nomenclature details as well, so it's not just you. > > Beyond the muscle memory aspect, nonsensical naming and inanely flat file > hierarchies annoy kernel developers and makes it harder for newbies to > understand the kernel source as well. > > The less clutter, the more organization, the better - and there's very > few valid technical reasons to add any new files or directories to the > top level directory - we should probably *remove* quite a few. > > For example 'firmware/' was recently moved to drivers/firmware/, and in a > similar fashion about a third of the remaining 22 directories should > probably be moved too: > > drwxr-xr-x arch > drwxr-xr-x block > drwxr-xr-x certs # move to build/certs/ dir > drwxr-xr-x crypto # move to kernel/crypto/ or security/crypto/ > drwxr-xr-x Documentation > drwxr-xr-x drivers > drwxr-xr-x fs > drwxr-xr-x include > drwxr-xr-x init > drwxr-xr-x ipc # move to kernel/ipc/ > drwxr-xr-x kernel > drwxr-xr-x lib > drwxr-xr-x LICENSES > drwxr-xr-x mm > drwxr-xr-x net > drwxr-xr-x samples # move to Documentation/samples/ > drwxr-xr-x scripts # move to build/scripts/ > drwxr-xr-x security > drwxr-xr-x sound # move to drivers/sound/ Heh, I was always surprised that sound/ made it into top level... and no, I'd not mind it being moved away. > There's a few borderline ones: > > - 'block' could in principle move to drivers/block/core/ but it's fine > at the top level too I think. > > - 'init' could in principle be moved to kernel/init/ - but it's not > wrong at the top level either. net would also make sense as drivers/net/core... That is what inspired sound/ afaict. > I'm volunteering to do this (in a scripted, repeatable, reviewable, > tweakable and "easy to execute in a quiet moment" fashion), although > I also expect you to balk at the churn. :-) I'd like to see that happen... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html