From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1716AC35280 for ; Mon, 30 Sep 2019 22:42:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9C5721906 for ; Mon, 30 Sep 2019 22:42:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbfI3Wmj (ORCPT ); Mon, 30 Sep 2019 18:42:39 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:20990 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726425AbfI3Wmj (ORCPT ); Mon, 30 Sep 2019 18:42:39 -0400 Received: from smtp2.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id 83B48A1A1C; Tue, 1 Oct 2019 00:42:30 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id i0Vf_5Qcnyhu; Tue, 1 Oct 2019 00:42:25 +0200 (CEST) Date: Tue, 1 Oct 2019 08:41:59 +1000 From: Aleksa Sarai To: kbuild test robot Cc: kbuild-all@01.org, Al Viro , Jeff Layton , "J. Bruce Fields" , Arnd Bergmann , David Howells , Shuah Khan , Shuah Khan , Ingo Molnar , Peter Zijlstra , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Alexander Shishkin , Rasmus Villemoes , Alexei Starovoitov , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, Jiri Olsa , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Tycho Andersen , Aleksa Sarai , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn , linuxppc-dev@lists.ozlabs.org, Andy Lutomirski , Namhyung Kim , David Drysdale , Christian Brauner , libc-alpha@sourceware.org, linux-parisc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-api@vger.kernel.org, Chanho Min , Oleg Nesterov , Eric Biederman , linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Linus Torvalds , containers@lists.linux-foundation.org Subject: Re: [PATCH v13 7/9] open: openat2(2) syscall Message-ID: <20190930224159.gp2hqm57qxlm2eat@yavin.dot.cyphar.com> References: <20190930183316.10190-8-cyphar@cyphar.com> <201910010404.WLqR1mUW%lkp@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t4elbyhlilsmpd4b" Content-Disposition: inline In-Reply-To: <201910010404.WLqR1mUW%lkp@intel.com> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org --t4elbyhlilsmpd4b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-10-01, kbuild test robot wrote: > Hi Aleksa, >=20 > Thank you for the patch! Yet something to improve: >=20 > [auto build test ERROR on linus/master] > [cannot apply to v5.4-rc1 next-20190930] > [if your patch is applied to the wrong git tree, please drop us a note to= help > improve the system. BTW, we also suggest to use '--base' option to specif= y the > base tree in git format-patch, please see https://stackoverflow.com/a/374= 06982] I forgot to include --base to signify this series depends on the copy_struct_from_user() one. I'll include it in the next version. > url: https://github.com/0day-ci/linux/commits/Aleksa-Sarai/namei-opena= t2-2-path-resolution-restrictions/20191001-025628 > config: i386-defconfig (attached as .config) > compiler: gcc-7 (Debian 7.4.0-13) 7.4.0 > reproduce: > # save the attached .config to linux build tree > make ARCH=3Di386=20 >=20 > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot >=20 > All errors (new ones prefixed by >>): >=20 > fs/open.c: In function '__do_sys_openat2': > >> fs/open.c:1173:8: error: implicit declaration of function 'copy_struct= _from_user'; did you mean 'copy_siginfo_from_user'? [-Werror=3Dimplicit-fun= ction-declaration] > err =3D copy_struct_from_user(&tmp, sizeof(tmp), how, usize); > ^~~~~~~~~~~~~~~~~~~~~ > copy_siginfo_from_user > cc1: some warnings being treated as errors >=20 > vim +1173 fs/open.c >=20 > 1163=09 > 1164 SYSCALL_DEFINE4(openat2, int, dfd, const char __user *, filename, > 1165 const struct open_how __user *, how, size_t, usize) > 1166 { > 1167 int err; > 1168 struct open_how tmp; > 1169=09 > 1170 if (unlikely(usize < OPEN_HOW_SIZE_VER0)) > 1171 return -EINVAL; > 1172=09 > > 1173 err =3D copy_struct_from_user(&tmp, sizeof(tmp), how, usize); > 1174 if (err) > 1175 return err; > 1176=09 > 1177 if (force_o_largefile()) > 1178 tmp.flags |=3D O_LARGEFILE; > 1179=09 > 1180 return do_sys_open(dfd, filename, &tmp); > 1181 } > 1182=09 >=20 > --- > 0-DAY kernel test infrastructure Open Source Technology Ce= nter > https://lists.01.org/pipermail/kbuild-all Intel Corpora= tion --=20 Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH --t4elbyhlilsmpd4b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXZKEtAAKCRCdlLljIbnQ EmxJAQDTSUj176CMMvs56b+zPL9VCZGAIFkQ+0fXCW8y6GyasAD/d8NBlZ2zmc9b DdtZcltEmeWc0Rd4LR1wAUrHajuvTAU= =sSPC -----END PGP SIGNATURE----- --t4elbyhlilsmpd4b--