archive mirror
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <>
To: Brendan Higgins <>
Cc: Randy Dunlap <>,
	"Theodore Ts'o" <>,
	KUnit Development <>
Subject: Re: should default to --build_dir=.kunit
Date: Thu, 17 Oct 2019 08:51:54 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Oct 16, 2019 at 02:04:35PM -0700, Brendan Higgins wrote:
> > > Should we maybe drop `--build_dir` in favor of `O`?
> >
> > Yes, preferably be consistent with the rest of the kernel makefiles.
> Alright, probably a good idea to make this change fairly soon then
> before we have to worry about backwards compatibility and such.

I'm not sure how this would work; so something like:

    .../ run O=/build_dir

Should other flags we can pass in via the makefile processing, such as
V=1, etc., also work?  What other things can we pass in via after the
"run" command?

And if we're going to go this far, maybe we should make "make kunit"
run tools/testing/kunit/

Some minor other nits if you're going to be making changes to's CLI parsing:

1) It would be nice if there was a help command so that "
   help" does what -h does.

2) The top-level help message should indicate that " run"
   takes various optional arguments and the way to find them is
   " run -h".  This was *not* obvious, and the way I figured
   out there was even --build_dir option was via purusing the source
   code.  (It wasn't in the documentation that I could find.)

3) And maybe then " help run" should display the help message
   for " urn".  This would make it consistent with other tools
   that some of us might be familiar with (e.g., gcloud, gsutil, etc.)

Of course, if the front entry for kunit starts being "make kunit" as
opposed to ./tools/testing/kunit/, then we really need to
figure out how to pass in the equivalent of --timeout.  (Maybe
--raw_output is enabled if we run make kunit V=1?).  And of course,
all of this would need to be documented.

					- Ted

  reply	other threads:[~2019-10-17 12:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2019-10-11 11:19 ` should default to --build_dir=.kunit Brendan Higgins
2019-10-11 14:56   ` Randy Dunlap
2019-10-16 21:04     ` Brendan Higgins
2019-10-17 12:51       ` Theodore Y. Ts'o [this message]
2019-10-18 22:12         ` Brendan Higgins
     [not found]   ` <>
2019-10-16 21:02     ` Brendan Higgins
2019-10-18 12:43       ` Luis Chamberlain
2019-10-18 22:22         ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).