linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Iurii Zaikin <yzaikin@google.com>
Cc: linux-kselftest@vger.kernel.org, linux-ext4@vger.kernel.org,
	skhan@linuxfoundation.org, adilger.kernel@dilger.ca,
	Tim.Bird@sony.com, kunit-dev@googlegroups.com,
	brendanhiggins@google.com
Subject: Re: [PATCH linux-kselftest/test v5] ext4: add kunit test for decoding extended timestamps
Date: Thu, 17 Oct 2019 09:03:04 -0400	[thread overview]
Message-ID: <20191017130304.GF25548@mit.edu> (raw)
In-Reply-To: <20191017125553.GE25548@mit.edu>

On Thu, Oct 17, 2019 at 08:55:53AM -0400, Theodore Y. Ts'o wrote:
> Minor nit.  The above commit description would look nicer when looked
> at in "git log" when formatted as follows:
> 
> --- cut here ---
> 
> KUnit tests for decoding extended 64 bit timestamps that verify the
> seconds part of [a/c/m] timestamps in ext4 inode structs are decoded
> correctly.
> 
> KUnit tests, which run on boot and output the results to the debug log
> in TAP format (http://testanything.org/) are only useful for kernel
> devs running KUnit test harness and are not for inclusion into a
> production build.
> 
> Test data is derived from the table in the Inode Timestamps section of
> Documentation/filesystems/ext4/inodes.rst.
> 
> --- cut here ---

Upon rereading, swapping the 2nd and 3rd paragraphis would read
better, I think.

      	   	    	     	 - Ted
				 

  reply	other threads:[~2019-10-17 13:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 20:58 Iurii Zaikin
2019-10-16 21:17 ` Brendan Higgins
2019-10-17 12:55 ` Theodore Y. Ts'o
2019-10-17 13:03   ` Theodore Y. Ts'o [this message]
2019-10-16 21:29 Iurii Zaikin
2019-10-17  0:10 ` Shuah Khan
2019-10-17 22:12   ` Iurii Zaikin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017130304.GF25548@mit.edu \
    --to=tytso@mit.edu \
    --cc=Tim.Bird@sony.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=brendanhiggins@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=yzaikin@google.com \
    --subject='Re: [PATCH linux-kselftest/test v5] ext4: add kunit test for decoding extended timestamps' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).