From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79FC0FA372A for ; Thu, 17 Oct 2019 13:03:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5839021835 for ; Thu, 17 Oct 2019 13:03:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390780AbfJQNDP (ORCPT ); Thu, 17 Oct 2019 09:03:15 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:35241 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728923AbfJQNDO (ORCPT ); Thu, 17 Oct 2019 09:03:14 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x9HD344Q005988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 17 Oct 2019 09:03:05 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 4732E420458; Thu, 17 Oct 2019 09:03:04 -0400 (EDT) Date: Thu, 17 Oct 2019 09:03:04 -0400 From: "Theodore Y. Ts'o" To: Iurii Zaikin Cc: linux-kselftest@vger.kernel.org, linux-ext4@vger.kernel.org, skhan@linuxfoundation.org, adilger.kernel@dilger.ca, Tim.Bird@sony.com, kunit-dev@googlegroups.com, brendanhiggins@google.com Subject: Re: [PATCH linux-kselftest/test v5] ext4: add kunit test for decoding extended timestamps Message-ID: <20191017130304.GF25548@mit.edu> References: <20191016205820.164985-1-yzaikin@google.com> <20191017125553.GE25548@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191017125553.GE25548@mit.edu> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Oct 17, 2019 at 08:55:53AM -0400, Theodore Y. Ts'o wrote: > Minor nit. The above commit description would look nicer when looked > at in "git log" when formatted as follows: > > --- cut here --- > > KUnit tests for decoding extended 64 bit timestamps that verify the > seconds part of [a/c/m] timestamps in ext4 inode structs are decoded > correctly. > > KUnit tests, which run on boot and output the results to the debug log > in TAP format (http://testanything.org/) are only useful for kernel > devs running KUnit test harness and are not for inclusion into a > production build. > > Test data is derived from the table in the Inode Timestamps section of > Documentation/filesystems/ext4/inodes.rst. > > --- cut here --- Upon rereading, swapping the 2nd and 3rd paragraphis would read better, I think. - Ted