* [PATCH] seccomp: fix SECCOMP_USER_NOTIF_FLAG_CONTINUE test [not found] <20191021084157.GG9296@shao2-debian> @ 2019-10-21 9:10 ` Christian Brauner 2019-10-21 13:50 ` Tycho Andersen 0 siblings, 1 reply; 3+ messages in thread From: Christian Brauner @ 2019-10-21 9:10 UTC (permalink / raw) To: linux-kernel, keescook Cc: rong.a.chen, ast, christian.brauner, daniel, kafai, lkp, luto, shuah, songliubraving, tycho, tyhicks, wad, yhs, linux-kselftest The ifndef for SECCOMP_USER_NOTIF_FLAG_CONTINUE was placed under the ifndef for the SECCOMP_FILTER_FLAG_NEW_LISTENER feature. This will not work on systems that do support SECCOMP_FILTER_FLAG_NEW_LISTENER but do not support SECCOMP_USER_NOTIF_FLAG_CONTINUE. So move the latter ifndef out of the former ifndef's scope. 2019-10-20 11:14:01 make run_tests -C seccomp make: Entering directory '/usr/src/perf_selftests-x86_64-rhel-7.6-0eebfed2954f152259cae0ad57b91d3ea92968e8/tools/testing/selftests/seccomp' gcc -Wl,-no-as-needed -Wall seccomp_bpf.c -lpthread -o seccomp_bpf seccomp_bpf.c: In function ‘user_notification_continue’: seccomp_bpf.c:3562:15: error: ‘SECCOMP_USER_NOTIF_FLAG_CONTINUE’ undeclared (first use in this function) resp.flags = SECCOMP_USER_NOTIF_FLAG_CONTINUE; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ seccomp_bpf.c:3562:15: note: each undeclared identifier is reported only once for each function it appears in Makefile:12: recipe for target 'seccomp_bpf' failed make: *** [seccomp_bpf] Error 1 make: Leaving directory '/usr/src/perf_selftests-x86_64-rhel-7.6-0eebfed2954f152259cae0ad57b91d3ea92968e8/tools/testing/selftests/seccomp' Reported-by: kernel test robot <rong.a.chen@intel.com> Fixes: 0eebfed2954f ("seccomp: test SECCOMP_USER_NOTIF_FLAG_CONTINUE") Cc: linux-kselftest@vger.kernel.org Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> --- tools/testing/selftests/seccomp/seccomp_bpf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c index 2519377ebda3..9669b81086cf 100644 --- a/tools/testing/selftests/seccomp/seccomp_bpf.c +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c @@ -168,10 +168,6 @@ struct seccomp_metadata { #define SECCOMP_RET_USER_NOTIF 0x7fc00000U -#ifndef SECCOMP_USER_NOTIF_FLAG_CONTINUE -#define SECCOMP_USER_NOTIF_FLAG_CONTINUE 0x00000001 -#endif - #define SECCOMP_IOC_MAGIC '!' #define SECCOMP_IO(nr) _IO(SECCOMP_IOC_MAGIC, nr) #define SECCOMP_IOR(nr, type) _IOR(SECCOMP_IOC_MAGIC, nr, type) @@ -205,6 +201,10 @@ struct seccomp_notif_sizes { }; #endif +#ifndef SECCOMP_USER_NOTIF_FLAG_CONTINUE +#define SECCOMP_USER_NOTIF_FLAG_CONTINUE 0x00000001 +#endif + #ifndef seccomp int seccomp(unsigned int op, unsigned int flags, void *args) { -- 2.23.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] seccomp: fix SECCOMP_USER_NOTIF_FLAG_CONTINUE test 2019-10-21 9:10 ` [PATCH] seccomp: fix SECCOMP_USER_NOTIF_FLAG_CONTINUE test Christian Brauner @ 2019-10-21 13:50 ` Tycho Andersen 2019-10-21 16:20 ` Kees Cook 0 siblings, 1 reply; 3+ messages in thread From: Tycho Andersen @ 2019-10-21 13:50 UTC (permalink / raw) To: Christian Brauner Cc: linux-kernel, keescook, rong.a.chen, ast, daniel, kafai, lkp, luto, shuah, songliubraving, tyhicks, wad, yhs, linux-kselftest On Mon, Oct 21, 2019 at 11:10:55AM +0200, Christian Brauner wrote: > The ifndef for SECCOMP_USER_NOTIF_FLAG_CONTINUE was placed under the > ifndef for the SECCOMP_FILTER_FLAG_NEW_LISTENER feature. This will not > work on systems that do support SECCOMP_FILTER_FLAG_NEW_LISTENER but do not > support SECCOMP_USER_NOTIF_FLAG_CONTINUE. So move the latter ifndef out of > the former ifndef's scope. > > 2019-10-20 11:14:01 make run_tests -C seccomp > make: Entering directory '/usr/src/perf_selftests-x86_64-rhel-7.6-0eebfed2954f152259cae0ad57b91d3ea92968e8/tools/testing/selftests/seccomp' > gcc -Wl,-no-as-needed -Wall seccomp_bpf.c -lpthread -o seccomp_bpf > seccomp_bpf.c: In function ‘user_notification_continue’: > seccomp_bpf.c:3562:15: error: ‘SECCOMP_USER_NOTIF_FLAG_CONTINUE’ undeclared (first use in this function) > resp.flags = SECCOMP_USER_NOTIF_FLAG_CONTINUE; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > seccomp_bpf.c:3562:15: note: each undeclared identifier is reported only once for each function it appears in > Makefile:12: recipe for target 'seccomp_bpf' failed > make: *** [seccomp_bpf] Error 1 > make: Leaving directory '/usr/src/perf_selftests-x86_64-rhel-7.6-0eebfed2954f152259cae0ad57b91d3ea92968e8/tools/testing/selftests/seccomp' > > Reported-by: kernel test robot <rong.a.chen@intel.com> > Fixes: 0eebfed2954f ("seccomp: test SECCOMP_USER_NOTIF_FLAG_CONTINUE") > Cc: linux-kselftest@vger.kernel.org > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> Reviewed-by: Tycho Andersen <tycho@tycho.ws> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] seccomp: fix SECCOMP_USER_NOTIF_FLAG_CONTINUE test 2019-10-21 13:50 ` Tycho Andersen @ 2019-10-21 16:20 ` Kees Cook 0 siblings, 0 replies; 3+ messages in thread From: Kees Cook @ 2019-10-21 16:20 UTC (permalink / raw) To: Tycho Andersen Cc: Christian Brauner, linux-kernel, rong.a.chen, ast, daniel, kafai, lkp, luto, shuah, songliubraving, tyhicks, wad, yhs, linux-kselftest On Mon, Oct 21, 2019 at 07:50:13AM -0600, Tycho Andersen wrote: > On Mon, Oct 21, 2019 at 11:10:55AM +0200, Christian Brauner wrote: > > The ifndef for SECCOMP_USER_NOTIF_FLAG_CONTINUE was placed under the > > ifndef for the SECCOMP_FILTER_FLAG_NEW_LISTENER feature. This will not > > work on systems that do support SECCOMP_FILTER_FLAG_NEW_LISTENER but do not > > support SECCOMP_USER_NOTIF_FLAG_CONTINUE. So move the latter ifndef out of > > the former ifndef's scope. > > > > 2019-10-20 11:14:01 make run_tests -C seccomp > > make: Entering directory '/usr/src/perf_selftests-x86_64-rhel-7.6-0eebfed2954f152259cae0ad57b91d3ea92968e8/tools/testing/selftests/seccomp' > > gcc -Wl,-no-as-needed -Wall seccomp_bpf.c -lpthread -o seccomp_bpf > > seccomp_bpf.c: In function ‘user_notification_continue’: > > seccomp_bpf.c:3562:15: error: ‘SECCOMP_USER_NOTIF_FLAG_CONTINUE’ undeclared (first use in this function) > > resp.flags = SECCOMP_USER_NOTIF_FLAG_CONTINUE; > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > seccomp_bpf.c:3562:15: note: each undeclared identifier is reported only once for each function it appears in > > Makefile:12: recipe for target 'seccomp_bpf' failed > > make: *** [seccomp_bpf] Error 1 > > make: Leaving directory '/usr/src/perf_selftests-x86_64-rhel-7.6-0eebfed2954f152259cae0ad57b91d3ea92968e8/tools/testing/selftests/seccomp' > > > > Reported-by: kernel test robot <rong.a.chen@intel.com> > > Fixes: 0eebfed2954f ("seccomp: test SECCOMP_USER_NOTIF_FLAG_CONTINUE") > > Cc: linux-kselftest@vger.kernel.org > > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com> > > Reviewed-by: Tycho Andersen <tycho@tycho.ws> Thanks! Applied to my for-next/seccomp tree. -- Kees Cook ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-21 16:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191021084157.GG9296@shao2-debian>
2019-10-21 9:10 ` [PATCH] seccomp: fix SECCOMP_USER_NOTIF_FLAG_CONTINUE test Christian Brauner
2019-10-21 13:50 ` Tycho Andersen
2019-10-21 16:20 ` Kees Cook
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).