linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [BUGFIX PATCH] selftests: breakpoints: Fix a typo of function name
@ 2019-10-31 12:23 Masami Hiramatsu
  2019-10-31 15:58 ` Kees Cook
  0 siblings, 1 reply; 2+ messages in thread
From: Masami Hiramatsu @ 2019-10-31 12:23 UTC (permalink / raw)
  To: Shuah Khan
  Cc: linux-kselftest, linux-kernel, jaswinder.singh, mhiramat,
	Jun Takahashi, Kees Cook

Since commit 5821ba969511 ("selftests: Add test plan API to kselftest.h
and adjust callers") accidentally introduced 'a' typo in the front of
run_test() function, breakpoint_test_arm64.c became not able to be
compiled.

Remove the 'a' from arun_test().

Fixes: 5821ba969511 ("selftests: Add test plan API to kselftest.h and adjust callers")
Reported-by: Jun Takahashi <takahashi.jun_s@aa.socionext.com>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
---
 .../selftests/breakpoints/breakpoint_test_arm64.c  |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
index 58ed5eeab709..ad41ea69001b 100644
--- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
+++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
@@ -109,7 +109,7 @@ static bool set_watchpoint(pid_t pid, int size, int wp)
 	return false;
 }
 
-static bool arun_test(int wr_size, int wp_size, int wr, int wp)
+static bool run_test(int wr_size, int wp_size, int wr, int wp)
 {
 	int status;
 	siginfo_t siginfo;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [BUGFIX PATCH] selftests: breakpoints: Fix a typo of function name
  2019-10-31 12:23 [BUGFIX PATCH] selftests: breakpoints: Fix a typo of function name Masami Hiramatsu
@ 2019-10-31 15:58 ` Kees Cook
  0 siblings, 0 replies; 2+ messages in thread
From: Kees Cook @ 2019-10-31 15:58 UTC (permalink / raw)
  To: Masami Hiramatsu
  Cc: Shuah Khan, linux-kselftest, linux-kernel, jaswinder.singh,
	Jun Takahashi

On Thu, Oct 31, 2019 at 09:23:00PM +0900, Masami Hiramatsu wrote:
> Since commit 5821ba969511 ("selftests: Add test plan API to kselftest.h
> and adjust callers") accidentally introduced 'a' typo in the front of
> run_test() function, breakpoint_test_arm64.c became not able to be
> compiled.
> 
> Remove the 'a' from arun_test().
> 
> Fixes: 5821ba969511 ("selftests: Add test plan API to kselftest.h and adjust callers")
> Reported-by: Jun Takahashi <takahashi.jun_s@aa.socionext.com>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Kees Cook <keescook@chromium.org>

Argh, apologies! Yes, thank you for catching this.

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  .../selftests/breakpoints/breakpoint_test_arm64.c  |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> index 58ed5eeab709..ad41ea69001b 100644
> --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c
> @@ -109,7 +109,7 @@ static bool set_watchpoint(pid_t pid, int size, int wp)
>  	return false;
>  }
>  
> -static bool arun_test(int wr_size, int wp_size, int wr, int wp)
> +static bool run_test(int wr_size, int wp_size, int wr, int wp)
>  {
>  	int status;
>  	siginfo_t siginfo;
> 

-- 
Kees Cook

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-31 15:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 12:23 [BUGFIX PATCH] selftests: breakpoints: Fix a typo of function name Masami Hiramatsu
2019-10-31 15:58 ` Kees Cook

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).