From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: "Shuah Khan" <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
jaswinder.singh@linaro.org,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Anshuman Khandual" <khandual@linux.vnet.ibm.com>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
"Eric Dumazet" <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
"Willem de Bruijn" <willemb@google.com>,
"Emilio López" <emilio.lopez@collabora.co.uk>
Subject: Re: [BUGFIX PATCH v3 0/5] selftests: Fixes for 32bit arch
Date: Thu, 31 Oct 2019 20:23:17 +0900 [thread overview]
Message-ID: <20191031202317.d264b984c4749af7abd43a84@kernel.org> (raw)
In-Reply-To: <157180665007.17298.907392422924029261.stgit@devnote2>
Hi,
Would anyone is OK for this fix?
I also found a typo on arm64 build... will send soon.
Thanks,
On Wed, 23 Oct 2019 13:57:30 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Hi,
>
> Here are the 3rd version of kselftest fixes some on 32bit arch
> (e.g. arm)
>
> In this version, I updated [1/5] to make va_max 1MB unconditionally
> according to Alexey's comment.
>
> When I built the ksefltest on arm, I hit some 32bit related warnings.
> Here are the patches to fix those issues.
>
>
> - [1/5] va_max was set 2^32 even on 32bit arch. This can make
> va_max == 0 and always fail. Make it 1GB unconditionally.
> - [2/5] Some VM tests requires 64bit user space, which should
> not run on 32bit arch.
> - [3/5] For counting the size of large file, we should use
> size_t instead of unsinged long.
> - [4/5] Gcc warns printf format for size_t and int64_t on
> 32bit arch. Use %llu and cast it.
> - [5/5] Gcc warns __u64 and pointer type castings. It should
> once translated to unsigned long.
>
> Thank you,
>
> ---
>
> Masami Hiramatsu (5):
> selftests: proc: Make va_max 1MB
> selftests: vm: Build/Run 64bit tests only on 64bit arch
> selftests: net: Use size_t and ssize_t for counting file size
> selftests: net: Fix printf format warnings on arm
> selftests: sync: Fix cast warnings on arm
>
>
> tools/testing/selftests/net/so_txtime.c | 4 ++--
> tools/testing/selftests/net/tcp_mmap.c | 8 ++++----
> tools/testing/selftests/net/udpgso.c | 3 ++-
> tools/testing/selftests/net/udpgso_bench_tx.c | 3 ++-
> .../selftests/proc/proc-self-map-files-002.c | 6 +++++-
> tools/testing/selftests/sync/sync.c | 6 +++---
> tools/testing/selftests/vm/Makefile | 5 +++++
> tools/testing/selftests/vm/run_vmtests | 10 ++++++++++
> 8 files changed, 33 insertions(+), 12 deletions(-)
>
> --
> Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2019-10-31 11:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 4:57 [BUGFIX PATCH v3 0/5] selftests: Fixes for 32bit arch Masami Hiramatsu
2019-10-23 4:57 ` [BUGFIX PATCH v3 1/5] selftests: proc: Make va_max 1MB Masami Hiramatsu
2019-10-23 4:57 ` [BUGFIX PATCH v3 2/5] selftests: vm: Build/Run 64bit tests only on 64bit arch Masami Hiramatsu
2019-10-23 4:57 ` [BUGFIX PATCH v3 3/5] selftests: net: Use size_t and ssize_t for counting file size Masami Hiramatsu
2019-10-23 4:58 ` [BUGFIX PATCH v3 4/5] selftests: net: Fix printf format warnings on arm Masami Hiramatsu
2019-10-23 4:58 ` [BUGFIX PATCH v3 5/5] selftests: sync: Fix cast " Masami Hiramatsu
2019-10-31 11:23 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031202317.d264b984c4749af7abd43a84@kernel.org \
--to=mhiramat@kernel.org \
--cc=adobriyan@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=emilio.lopez@collabora.co.uk \
--cc=jaswinder.singh@linaro.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).