* [PATCH] kselftests/dmabuf-heaps: Fix compiler error in one condition
@ 2019-11-01 2:04 Xiao Yang
2019-11-01 2:25 ` Xiao Yang
0 siblings, 1 reply; 5+ messages in thread
From: Xiao Yang @ 2019-11-01 2:04 UTC (permalink / raw)
To: john.stultz, shuah; +Cc: linux-kselftest, Xiao Yang
Compiling dmabuf-heaps cannot locate headers and then gets the following
error when kernel source code instead of system provides headers:
-------------------------------------------
dmabuf-heap.c:16:10: fatal error: drm/drm.h: No such file or directory
-------------------------------------------
Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
---
tools/testing/selftests/dmabuf-heaps/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/dmabuf-heaps/Makefile b/tools/testing/selftests/dmabuf-heaps/Makefile
index 8c4c36e2972d..9043e0b5a432 100644
--- a/tools/testing/selftests/dmabuf-heaps/Makefile
+++ b/tools/testing/selftests/dmabuf-heaps/Makefile
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
-CFLAGS += -static -O3 -Wl,-no-as-needed -Wall
+CFLAGS += -static -O3 -Wl,-no-as-needed -Wall -I../../../../usr/include
#LDLIBS += -lrt -lpthread -lm
# these are all "safe" tests that don't modify
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] kselftests/dmabuf-heaps: Fix compiler error in one condition
2019-11-01 2:04 [PATCH] kselftests/dmabuf-heaps: Fix compiler error in one condition Xiao Yang
@ 2019-11-01 2:25 ` Xiao Yang
2019-11-07 20:37 ` shuah
0 siblings, 1 reply; 5+ messages in thread
From: Xiao Yang @ 2019-11-01 2:25 UTC (permalink / raw)
To: john.stultz, shuah; +Cc: linux-kselftest, philip.li
Hi,
If you fix the issue, kindly add following tag
Reported-by: kernel test robot <lkp@intel.com>
On 11/1/19 10:04 AM, Xiao Yang wrote:
> Compiling dmabuf-heaps cannot locate headers and then gets the following
> error when kernel source code instead of system provides headers:
> -------------------------------------------
> dmabuf-heap.c:16:10: fatal error: drm/drm.h: No such file or directory
> -------------------------------------------
>
> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
> ---
> tools/testing/selftests/dmabuf-heaps/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/dmabuf-heaps/Makefile b/tools/testing/selftests/dmabuf-heaps/Makefile
> index 8c4c36e2972d..9043e0b5a432 100644
> --- a/tools/testing/selftests/dmabuf-heaps/Makefile
> +++ b/tools/testing/selftests/dmabuf-heaps/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> -CFLAGS += -static -O3 -Wl,-no-as-needed -Wall
> +CFLAGS += -static -O3 -Wl,-no-as-needed -Wall -I../../../../usr/include
> #LDLIBS += -lrt -lpthread -lm
>
> # these are all "safe" tests that don't modify
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kselftests/dmabuf-heaps: Fix compiler error in one condition
2019-11-01 2:25 ` Xiao Yang
@ 2019-11-07 20:37 ` shuah
2019-11-07 20:39 ` John Stultz
0 siblings, 1 reply; 5+ messages in thread
From: shuah @ 2019-11-07 20:37 UTC (permalink / raw)
To: Xiao Yang, john.stultz; +Cc: linux-kselftest, philip.li, shuah
On 10/31/19 8:25 PM, Xiao Yang wrote:
> Hi,
>
> If you fix the issue, kindly add following tag
> Reported-by: kernel test robot <lkp@intel.com>
>
Do you plan to send another patch? I don't understand
if this meant you think this patch doesn't fix the
problem?
> On 11/1/19 10:04 AM, Xiao Yang wrote:
>> Compiling dmabuf-heaps cannot locate headers and then gets the following
>> error when kernel source code instead of system provides headers:
>> -------------------------------------------
>> dmabuf-heap.c:16:10: fatal error: drm/drm.h: No such file or directory
>> -------------------------------------------
>>
>> Signed-off-by: Xiao Yang <ice_yangxiao@163.com>
>> ---
>> tools/testing/selftests/dmabuf-heaps/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/dmabuf-heaps/Makefile
>> b/tools/testing/selftests/dmabuf-heaps/Makefile
>> index 8c4c36e2972d..9043e0b5a432 100644
>> --- a/tools/testing/selftests/dmabuf-heaps/Makefile
>> +++ b/tools/testing/selftests/dmabuf-heaps/Makefile
>> @@ -1,5 +1,5 @@
>> # SPDX-License-Identifier: GPL-2.0
>> -CFLAGS += -static -O3 -Wl,-no-as-needed -Wall
>> +CFLAGS += -static -O3 -Wl,-no-as-needed -Wall -I../../../../usr/include
>> #LDLIBS += -lrt -lpthread -lm
>> # these are all "safe" tests that don't modify
>
>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kselftests/dmabuf-heaps: Fix compiler error in one condition
2019-11-07 20:37 ` shuah
@ 2019-11-07 20:39 ` John Stultz
2019-11-07 21:10 ` shuah
0 siblings, 1 reply; 5+ messages in thread
From: John Stultz @ 2019-11-07 20:39 UTC (permalink / raw)
To: shuah; +Cc: Xiao Yang, linux-kselftest, philip.li
On Thu, Nov 7, 2019 at 12:37 PM shuah <shuah@kernel.org> wrote:
>
> On 10/31/19 8:25 PM, Xiao Yang wrote:
> > Hi,
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> Do you plan to send another patch? I don't understand
> if this meant you think this patch doesn't fix the
> problem?
I've actually folded in the fix into my patches.
thanks
-john
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] kselftests/dmabuf-heaps: Fix compiler error in one condition
2019-11-07 20:39 ` John Stultz
@ 2019-11-07 21:10 ` shuah
0 siblings, 0 replies; 5+ messages in thread
From: shuah @ 2019-11-07 21:10 UTC (permalink / raw)
To: John Stultz; +Cc: Xiao Yang, linux-kselftest, philip.li, shuah
On 11/7/19 1:39 PM, John Stultz wrote:
> On Thu, Nov 7, 2019 at 12:37 PM shuah <shuah@kernel.org> wrote:
>>
>> On 10/31/19 8:25 PM, Xiao Yang wrote:
>>> Hi,
>>>
>>> If you fix the issue, kindly add following tag
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>> Do you plan to send another patch? I don't understand
>> if this meant you think this patch doesn't fix the
>> problem?
>
> I've actually folded in the fix into my patches.
>
> thanks
> -john
>
Thanks for the clarification.
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-07 21:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 2:04 [PATCH] kselftests/dmabuf-heaps: Fix compiler error in one condition Xiao Yang
2019-11-01 2:25 ` Xiao Yang
2019-11-07 20:37 ` shuah
2019-11-07 20:39 ` John Stultz
2019-11-07 21:10 ` shuah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).