From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD10C5DF63 for ; Wed, 6 Nov 2019 16:00:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2886F2178F for ; Wed, 6 Nov 2019 16:00:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728373AbfKFQAj (ORCPT ); Wed, 6 Nov 2019 11:00:39 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:57102 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727192AbfKFQAj (ORCPT ); Wed, 6 Nov 2019 11:00:39 -0500 Received: from [213.220.153.21] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iSNjY-0003JQ-Ax; Wed, 06 Nov 2019 16:00:36 +0000 Date: Wed, 6 Nov 2019 17:00:35 +0100 From: Christian Brauner To: Adrian Reber Cc: Shuah Khan , Eugene Syromiatnikov , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests: add tests for clone3() Message-ID: <20191106160034.73wla62ndojfz4rq@wittgenstein> References: <20191104131846.1076814-1-areber@redhat.com> <20191106155914.hzolyolz2w4hcn7w@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191106155914.hzolyolz2w4hcn7w@wittgenstein> User-Agent: NeoMutt/20180716 Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Nov 06, 2019 at 04:59:14PM +0100, Christian Brauner wrote: > On Mon, Nov 04, 2019 at 02:18:46PM +0100, Adrian Reber wrote: > > This adds tests for clone3() with different values and sizes > > of struct clone_args. > > > > This selftest was initially part of of the clone3() with PID selftest. > > After that patch was almost merged Eugene sent out a couple of patches > > to fix problems with these test. > > > > This commit now only contains the clone3() selftest after the LPC > > decision to rework clone3() with PID to allow setting the PID in > > multiple PID namespaces including all of Eugene's patches. > > > > Signed-off-by: Eugene Syromiatnikov > > Signed-off-by: Adrian Reber > > Resending, since mutt messed-up the quoting due to a new configuration I > was testing. > > A few more comments below. > > Also, would you be open to adding tests here for the newly added .stack > and .stack_size API (cf. [1])? Actually, forget that part for now. We can do this later in a separate patchset. Christian