From: Christian Brauner <christian.brauner@ubuntu.com>
To: Adrian Reber <areber@redhat.com>
Cc: Shuah Khan <shuah@kernel.org>,
Eugene Syromiatnikov <esyr@redhat.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: add tests for clone3()
Date: Fri, 8 Nov 2019 09:29:39 +0100 [thread overview]
Message-ID: <20191108082937.ypc5t2fcr2ffmlmm@wittgenstein> (raw)
In-Reply-To: <20191108064416.GA153851@dcbz.redhat.com>
On Fri, Nov 08, 2019 at 07:44:16AM +0100, Adrian Reber wrote:
> On Wed, Nov 06, 2019 at 04:59:15PM +0100, Christian Brauner wrote:
> > On Mon, Nov 04, 2019 at 02:18:46PM +0100, Adrian Reber wrote:
> Not sure myself. It was just to make sure clone3() does not something
> unexpected when given wrong and unexpected input. It is the opposite to
> setting everything to zero. Not sure how much sense it makes, but as it
> already exists I would say to just keep it.
If it serves no real purpose then please remove it. It's not clear from
thist test _why_ it it expected to fail. Is it because of invalid stack
and stack_size or invalid tls etc.
>
> > > + args.flags = 1;
> > > + args.pidfd = 1;
> > > + args.child_tid = 1;
> > > + args.parent_tid = 1;
> > > + args.exit_signal = 1;
> > > + args.stack = 1;
> > > + args.stack_size = 1;
> > > + args.tls = 1;
> > > + break;
> > > + case CLONE3_ARGS_INVAL_EXIT_SIGNAL_BIG:
> [...]
>
> Let me know if you think that the CLONE3_ARGS_ALL_1 should really be
> removed. I will fix the other two things you mentioned and resend a new
> version.
Yes, please.
Christian
prev parent reply other threads:[~2019-11-08 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 13:18 [PATCH v2] selftests: add tests for clone3() Adrian Reber
2019-11-06 15:53 ` Christian Brauner
2019-11-06 15:59 ` Christian Brauner
2019-11-06 16:00 ` Christian Brauner
2019-11-08 6:44 ` Adrian Reber
2019-11-08 8:29 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108082937.ypc5t2fcr2ffmlmm@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=areber@redhat.com \
--cc=esyr@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).