From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 947BEC43331 for ; Wed, 13 Nov 2019 00:08:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 618E921E6F for ; Wed, 13 Nov 2019 00:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573603719; bh=KjzzTcYnHTbPiZHHU3oiNXK2IO0S++IshKJ56E3fWIM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=cEz3cgKVJLx4i0DyG2z39GseSoxoP1Mg1V+SNnzrR1Qew48cYNi3OGTGf+sxRzVxe ok/f7Uu3G3quACyg7Ux656bqq42am4nahZLBb6L8kdYZ5Am8GWXoxj9IZKa6O3jbDw wFRxXg1HNjIOgYN0rPbH+UVOMYG2di+19LIPuzGQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727065AbfKMAIj (ORCPT ); Tue, 12 Nov 2019 19:08:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:49868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726957AbfKMAIj (ORCPT ); Tue, 12 Nov 2019 19:08:39 -0500 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 273AA2196E; Wed, 13 Nov 2019 00:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573603718; bh=KjzzTcYnHTbPiZHHU3oiNXK2IO0S++IshKJ56E3fWIM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LOiGsvx+c2husp91s1WCl9gljHVh7c5xjNQNDyeBqhxPkRhboXxQqmqoTBCQPqQZ1 V2L9yuouLTv+rFxK1urn3WJ2bX10DDbmxjicANXYOddYCrZUMzv4RI1uer5JQH180k Lv+aNCMejDxus+4oUYACPPj8wFzi6MgoCQydwG18= Date: Tue, 12 Nov 2019 16:08:35 -0800 From: Andrew Morton To: Ralph Campbell Cc: Christoph Hellwig , Jerome Glisse , John Hubbard , Jason Gunthorpe , Shuah Khan , , , , Subject: Re: [PATCH v4 2/2] mm/hmm/test: add self tests for HMM Message-Id: <20191112160835.9bfa58cf756683ddc8d470fd@linux-foundation.org> In-Reply-To: <07589a71-3984-b2a6-b24b-6b9a23e1b60d@nvidia.com> References: <20191104222141.5173-1-rcampbell@nvidia.com> <20191104222141.5173-3-rcampbell@nvidia.com> <20191112152521.GC12550@lst.de> <07589a71-3984-b2a6-b24b-6b9a23e1b60d@nvidia.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue, 12 Nov 2019 13:51:11 -0800 Ralph Campbell wrote: > On 11/12/19 7:25 AM, Christoph Hellwig wrote: > > Shouldn't this go into mm/ instead? It certainly doesn't seem > > like a library. > > I was following the convention for the other vm test kernel modules. > I see a couple of modules in mm/ but I don't have a personal > preference for where to place it. > > Andrew, do you have a preference? q:/usr/src/25> ls -l lib/test_*.c|wc 33 297 2051 lib/ is a somewhat strange place, but I'd use that for now. Presumably one day someone will (pointlessly) move these into lib/test-modules/. Then into lib/test-modules/mm/, etc..