From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3267C432C3 for ; Thu, 21 Nov 2019 22:12:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3EE3206D8 for ; Thu, 21 Nov 2019 22:12:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbfKUWMg (ORCPT ); Thu, 21 Nov 2019 17:12:36 -0500 Received: from mga03.intel.com ([134.134.136.65]:47756 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfKUWMg (ORCPT ); Thu, 21 Nov 2019 17:12:36 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 14:12:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,227,1571727600"; d="scan'208";a="205292088" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga007.fm.intel.com with ESMTP; 21 Nov 2019 14:12:34 -0800 Date: Thu, 21 Nov 2019 14:12:34 -0800 From: Sean Christopherson To: Borislav Petkov Cc: Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Tony Luck , Tony W Wang-oc , Shuah Khan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-edac@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 04/19] x86/intel: Initialize IA32_FEATURE_CONTROL MSR at boot Message-ID: <20191121221234.GE16617@linux.intel.com> References: <20191119031240.7779-1-sean.j.christopherson@intel.com> <20191119031240.7779-5-sean.j.christopherson@intel.com> <20191121103925.GB20907@linux.intel.com> <20191121104145.GC20907@linux.intel.com> <20191121110533.GD6540@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121110533.GD6540@zn.tnic> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Nov 21, 2019 at 12:05:33PM +0100, Borislav Petkov wrote: > On Thu, Nov 21, 2019 at 12:41:45PM +0200, Jarkko Sakkinen wrote: > > On Thu, Nov 21, 2019 at 12:39:25PM +0200, Jarkko Sakkinen wrote: > > > > +void init_feature_control_msr(struct cpuinfo_x86 *c) > > > > I'd also use here shorter init_feat_ctl_msr(). It has one call site > > but shorter name is more convenient when playing with tracing tools. > > Yeah, and since we're shortening all to feat_ctl, let's do: > > mv arch/x86/kernel/cpu/feature_control.c arch/x86/kernel/cpu/feat_ctl.c Any objection to keeping the MSR name as MSR_IA32_FEATURE_CONTOL? I'd like to have some anchor back to the name used in the SDM. Any opinions/thoughts on the name of the Kconfig? Currently it's X86_FEATURE_CONTROL_MSR, which gets a bit long with CONFIG_ on the front. I also overlooked that we have MSR_MISC_FEATURE_CONTROL, so having IA32 in the Kconfig would probably be a good idea. X86_IA32 is rather redundant, so maybe IA32_FEAT_CTL or IA32_FEATURE_CONTROL?