From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C025C432C0 for ; Sun, 24 Nov 2019 21:35:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC3D32075E for ; Sun, 24 Nov 2019 21:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726952AbfKXVfd (ORCPT ); Sun, 24 Nov 2019 16:35:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:48950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726940AbfKXVfd (ORCPT ); Sun, 24 Nov 2019 16:35:33 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 060F820748; Sun, 24 Nov 2019 21:35:31 +0000 (UTC) Date: Sun, 24 Nov 2019 16:35:29 -0500 From: Steven Rostedt To: Masami Hiramatsu Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUGFIX PATCH 1/3] selftests/ftrace: Fix to check the existence of set_ftrace_filter Message-ID: <20191124163426.649ce5a1@oasis.local.home> In-Reply-To: <157457133923.25666.16444621591775429575.stgit@devnote2> References: <157457133001.25666.5309062776021151107.stgit@devnote2> <157457133923.25666.16444621591775429575.stgit@devnote2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Sun, 24 Nov 2019 13:55:39 +0900 Masami Hiramatsu wrote: > If we run ftracetest on the kernel with CONFIG_FUNCTION_TRACER=n, > there is no set_ftrace_filter and all test cases are failed, Note, that we can have CONFIG_FUNCTION_TRACER=y and there be no set_ftrace_filter. That is determined by CONFIG_DYNAMIC_FTRACE. I guess we should probably still check for that for this test, but I just wanted to state that set_ftrace_filter is not dependent on FUNCTION_TRACER but instead DYNAMIC_FTRACE. > because reset_ftrace_filter returns an error. > Let's check whether set_ftrace_filter exists and remove redundant > set_ftrace_filter from initialize_ftrace(). > > Signed-off-by: Masami Hiramatsu > --- > tools/testing/selftests/ftrace/test.d/functions | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/functions b/tools/testing/selftests/ftrace/test.d/functions > index 86986c4bba54..19d288cdf336 100644 > --- a/tools/testing/selftests/ftrace/test.d/functions > +++ b/tools/testing/selftests/ftrace/test.d/functions > @@ -46,6 +46,9 @@ reset_events_filter() { # reset all current setting filters > } > > reset_ftrace_filter() { # reset all triggers in set_ftrace_filter > + if [ ! -f set_ftrace_filter ]; then > + return 0 > + fi > echo > set_ftrace_filter > grep -v '^#' set_ftrace_filter | while read t; do > tr=`echo $t | cut -d: -f2` > @@ -93,7 +96,6 @@ initialize_ftrace() { # Reset ftrace to initial-state > disable_events > [ -f set_event_pid ] && echo > set_event_pid > [ -f set_ftrace_pid ] && echo > set_ftrace_pid > - [ -f set_ftrace_filter ] && echo | tee set_ftrace_* This also resets set_ftrace_notrace, which reset_ftrace_filter does not. -- Steve > [ -f set_graph_function ] && echo | tee set_graph_* > [ -f stack_trace_filter ] && echo > stack_trace_filter > [ -f kprobe_events ] && echo > kprobe_events