From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX PATCH 2/3] selftests/ftrace: Fix ftrace test cases to check unsupported
Date: Sun, 24 Nov 2019 16:39:57 -0500 [thread overview]
Message-ID: <20191124163957.6ff9d4e4@oasis.local.home> (raw)
In-Reply-To: <157457134852.25666.7660419621672440723.stgit@devnote2>
On Sun, 24 Nov 2019 13:55:48 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Since function tracer can be disabled, set_ftrace_filter can be
> disappeared. The test cases must check whether the set_ftrace_filter
> exists or not before testing and if not, return it as unsupported.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> .../ftrace/test.d/ftrace/func-filter-stacktrace.tc | 2 ++
> .../selftests/ftrace/test.d/ftrace/func_cpumask.tc | 5 +++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-stacktrace.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-stacktrace.tc
> index 36fb59f886ea..1a52f2883fe0 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-stacktrace.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-stacktrace.tc
> @@ -3,6 +3,8 @@
> # description: ftrace - stacktrace filter command
> # flags: instance
>
> +[ ! -f set_ftrace_filter ] && exit_unsupported
> +
> echo _do_fork:stacktrace >> set_ftrace_filter
>
> grep -q "_do_fork:stacktrace:unlimited" set_ftrace_filter
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
> index 86a1f07ef2ca..7757b549f0b6 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
> @@ -15,6 +15,11 @@ if [ $NP -eq 1 ] ;then
> exit_unresolved
> fi
>
> +if ! grep -q function available_tracers ; then
> + echo "Function trace is not enabled"
> + exit_unsupported
> +fi
This change is not described in the change log.
-- Steve
> +
> ORIG_CPUMASK=`cat tracing_cpumask`
>
> do_reset() {
next prev parent reply other threads:[~2019-11-24 21:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 4:55 [BUGFIX PATCH 0/3] selftests/ftrace: Fix ftracetest testcases for non-function tracer case Masami Hiramatsu
2019-11-24 4:55 ` [BUGFIX PATCH 1/3] selftests/ftrace: Fix to check the existence of set_ftrace_filter Masami Hiramatsu
2019-11-24 21:35 ` Steven Rostedt
2019-11-24 23:34 ` Masami Hiramatsu
2019-11-24 4:55 ` [BUGFIX PATCH 2/3] selftests/ftrace: Fix ftrace test cases to check unsupported Masami Hiramatsu
2019-11-24 21:39 ` Steven Rostedt [this message]
2019-11-24 23:36 ` Masami Hiramatsu
2019-11-24 4:55 ` [BUGFIX PATCH 3/3] selftests/ftrace: Do not to use absolute debugfs path Masami Hiramatsu
2019-11-24 21:42 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124163957.6ff9d4e4@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).