From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66300C432C0 for ; Sun, 24 Nov 2019 23:36:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36C272075E for ; Sun, 24 Nov 2019 23:36:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574638578; bh=iB/Oa/iihBYoB1/ANEWB3bGeCJwRbX8FrKU/p3OELT0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=G+tNNPsCnq30ZOUbvegbvI+jMC+XkC90KdD2kGBgQ71JR2Z8FYPlQsVeWL1Vgm6kg XgGjAGkzwFFHbdTj+MCwo5TG9EoWMXteicotR1vs5H1q+lse21Jdj/XMh8JwX1syqJ gQx1GuTjZlQ3EalonHQA89zgDgIwWb0o3/wXohkQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbfKXXgR (ORCPT ); Sun, 24 Nov 2019 18:36:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:58226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726957AbfKXXgR (ORCPT ); Sun, 24 Nov 2019 18:36:17 -0500 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E6C020718; Sun, 24 Nov 2019 23:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574638577; bh=iB/Oa/iihBYoB1/ANEWB3bGeCJwRbX8FrKU/p3OELT0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UAfY1kc2v+aEMuZ8aP2vsuT7x2DA3Zo/92UPhMeGlUr8PFhujUy81YxZHg2Hc4NIz 1Ynm3RK2WcXGh1WV5rRakpmccNX+FhDGtiIffIHD3BVGAHIxdS2oomHjtCflg1haw1 tvzoxIJjtE5u+PxxtxTHOxgqGALcNQFZj9V9428s= Date: Mon, 25 Nov 2019 08:36:14 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUGFIX PATCH 2/3] selftests/ftrace: Fix ftrace test cases to check unsupported Message-Id: <20191125083614.6f45d239c54c2df8601fa505@kernel.org> In-Reply-To: <20191124163957.6ff9d4e4@oasis.local.home> References: <157457133001.25666.5309062776021151107.stgit@devnote2> <157457134852.25666.7660419621672440723.stgit@devnote2> <20191124163957.6ff9d4e4@oasis.local.home> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Sun, 24 Nov 2019 16:39:57 -0500 Steven Rostedt wrote: > On Sun, 24 Nov 2019 13:55:48 +0900 > Masami Hiramatsu wrote: > > > Since function tracer can be disabled, set_ftrace_filter can be > > disappeared. The test cases must check whether the set_ftrace_filter > > exists or not before testing and if not, return it as unsupported. > > > > Signed-off-by: Masami Hiramatsu > > --- > > .../ftrace/test.d/ftrace/func-filter-stacktrace.tc | 2 ++ > > .../selftests/ftrace/test.d/ftrace/func_cpumask.tc | 5 +++++ > > 2 files changed, 7 insertions(+) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-stacktrace.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-stacktrace.tc > > index 36fb59f886ea..1a52f2883fe0 100644 > > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-stacktrace.tc > > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-stacktrace.tc > > @@ -3,6 +3,8 @@ > > # description: ftrace - stacktrace filter command > > # flags: instance > > > > +[ ! -f set_ftrace_filter ] && exit_unsupported > > + > > echo _do_fork:stacktrace >> set_ftrace_filter > > > > grep -q "_do_fork:stacktrace:unlimited" set_ftrace_filter > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc > > index 86a1f07ef2ca..7757b549f0b6 100644 > > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc > > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc > > @@ -15,6 +15,11 @@ if [ $NP -eq 1 ] ;then > > exit_unresolved > > fi > > > > +if ! grep -q function available_tracers ; then > > + echo "Function trace is not enabled" > > + exit_unsupported > > +fi > > This change is not described in the change log. Oops, my mistake. Thanks! > > -- Steve > > > + > > ORIG_CPUMASK=`cat tracing_cpumask` > > > > do_reset() { > -- Masami Hiramatsu