From: Matthias Kaehlcke <mka@chromium.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Artur Świgoń" <a.swigon@partner.samsung.com>,
"Angus Ainslie" <angus@akkea.ca>,
"Brendan Higgins" <brendanhiggins@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-pm@vger.kernel.org, linux-imx@nxp.com
Subject: Re: [PATCH v3 3/4] PM / QoS: Reorder pm_qos/freq_qos/dev_pm_qos structs
Date: Mon, 25 Nov 2019 14:22:10 -0800 [thread overview]
Message-ID: <20191125222210.GC228856@google.com> (raw)
In-Reply-To: <f6d6572ad860d479416108a41f0e20d5cb72ae46.1574699610.git.leonard.crestez@nxp.com>
On Mon, Nov 25, 2019 at 06:42:18PM +0200, Leonard Crestez wrote:
> This allows dev_pm_qos to embed freq_qos structs, which is done in the
> next patch. Separate commit to make it easier to review.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> include/linux/pm_qos.h | 74 ++++++++++++++++++++++--------------------
> 1 file changed, 38 insertions(+), 36 deletions(-)
>
> diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h
> index 24a6263c9931..678fec6da5b9 100644
> --- a/include/linux/pm_qos.h
> +++ b/include/linux/pm_qos.h
> @@ -47,25 +47,10 @@ struct pm_qos_request {
> struct pm_qos_flags_request {
> struct list_head node;
> s32 flags; /* Do not change to 64 bit */
> };
>
> -enum dev_pm_qos_req_type {
> - DEV_PM_QOS_RESUME_LATENCY = 1,
> - DEV_PM_QOS_LATENCY_TOLERANCE,
> - DEV_PM_QOS_FLAGS,
> -};
> -
> -struct dev_pm_qos_request {
> - enum dev_pm_qos_req_type type;
> - union {
> - struct plist_node pnode;
> - struct pm_qos_flags_request flr;
> - } data;
> - struct device *dev;
> -};
> -
> enum pm_qos_type {
> PM_QOS_UNITIALIZED,
> PM_QOS_MAX, /* return the largest value */
> PM_QOS_MIN, /* return the smallest value */
> PM_QOS_SUM /* return the sum */
> @@ -88,10 +73,48 @@ struct pm_qos_constraints {
> struct pm_qos_flags {
> struct list_head list;
> s32 effective_flags; /* Do not change to 64 bit */
> };
>
> +
> +#define FREQ_QOS_MIN_DEFAULT_VALUE 0
> +#define FREQ_QOS_MAX_DEFAULT_VALUE S32_MAX
> +
> +enum freq_qos_req_type {
> + FREQ_QOS_MIN = 1,
> + FREQ_QOS_MAX,
> +};
> +
> +struct freq_constraints {
> + struct pm_qos_constraints min_freq;
> + struct blocking_notifier_head min_freq_notifiers;
> + struct pm_qos_constraints max_freq;
> + struct blocking_notifier_head max_freq_notifiers;
> +};
> +
> +struct freq_qos_request {
> + enum freq_qos_req_type type;
> + struct plist_node pnode;
> + struct freq_constraints *qos;
> +};
> +
> +
> +enum dev_pm_qos_req_type {
> + DEV_PM_QOS_RESUME_LATENCY = 1,
> + DEV_PM_QOS_LATENCY_TOLERANCE,
> + DEV_PM_QOS_FLAGS,
> +};
> +
> +struct dev_pm_qos_request {
> + enum dev_pm_qos_req_type type;
> + union {
> + struct plist_node pnode;
> + struct pm_qos_flags_request flr;
> + } data;
> + struct device *dev;
> +};
> +
> struct dev_pm_qos {
> struct pm_qos_constraints resume_latency;
> struct pm_qos_constraints latency_tolerance;
> struct pm_qos_flags flags;
> struct dev_pm_qos_request *resume_latency_req;
> @@ -253,31 +276,10 @@ static inline s32 dev_pm_qos_raw_resume_latency(struct device *dev)
> {
> return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT;
> }
> #endif
>
> -#define FREQ_QOS_MIN_DEFAULT_VALUE 0
> -#define FREQ_QOS_MAX_DEFAULT_VALUE S32_MAX
> -
> -enum freq_qos_req_type {
> - FREQ_QOS_MIN = 1,
> - FREQ_QOS_MAX,
> -};
> -
> -struct freq_constraints {
> - struct pm_qos_constraints min_freq;
> - struct blocking_notifier_head min_freq_notifiers;
> - struct pm_qos_constraints max_freq;
> - struct blocking_notifier_head max_freq_notifiers;
> -};
> -
> -struct freq_qos_request {
> - enum freq_qos_req_type type;
> - struct plist_node pnode;
> - struct freq_constraints *qos;
> -};
> -
> static inline int freq_qos_request_active(struct freq_qos_request *req)
> {
> return !IS_ERR_OR_NULL(req->qos);
> }
>
> --
> 2.17.1
>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2019-11-25 22:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 16:42 [PATCH v3 0/4] PM: QoS: Restore DEV_PM_QOS_MIN/MAX_FREQUENCY Leonard Crestez
2019-11-25 16:42 ` [PATCH v3 1/4] PM / QoS: Initial kunit test Leonard Crestez
2019-11-25 20:19 ` Matthias Kaehlcke
2019-11-26 12:36 ` Leonard Crestez
2019-11-25 16:42 ` [PATCH v3 2/4] PM / QOS: Redefine FREQ_QOS_MAX_DEFAULT_VALUE to S32_MAX Leonard Crestez
2019-11-25 21:09 ` Matthias Kaehlcke
2019-11-25 16:42 ` [PATCH v3 3/4] PM / QoS: Reorder pm_qos/freq_qos/dev_pm_qos structs Leonard Crestez
2019-11-25 22:22 ` Matthias Kaehlcke [this message]
2019-11-25 16:42 ` [PATCH v3 4/4] PM / QoS: Restore DEV_PM_QOS_MIN/MAX_FREQUENCY Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125222210.GC228856@google.com \
--to=mka@chromium.org \
--cc=a.swigon@partner.samsung.com \
--cc=angus@akkea.ca \
--cc=brendanhiggins@google.com \
--cc=cw00.choi@samsung.com \
--cc=kunit-dev@googlegroups.com \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).