From: Masami Hiramatsu <mhiramat@kernel.org>
To: Shuah Khan <shuah@kernel.org>, Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUGFIX PATCH v4 2/4] selftests/ftrace: Fix ftrace test cases to check unsupported
Date: Wed, 27 Nov 2019 08:31:23 +0900 [thread overview]
Message-ID: <20191127083123.0257d2c450bfd87b0691300d@kernel.org> (raw)
In-Reply-To: <20191126124901.22ae2f9f@gandalf.local.home>
On Tue, 26 Nov 2019 12:49:01 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 26 Nov 2019 17:34:24 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
> > @@ -15,6 +15,11 @@ if [ $NP -eq 1 ] ;then
> > exit_unresolved
> > fi
> >
> > +if ! grep -q function available_tracers ; then
> > + echo "Function trace is not enabled"
> > + exit_unsupported
> > +fi
> > +
> > ORIG_CPUMASK=`cat tracing_cpumask`
>
> Strange, but the bashism test failed:
>
> ++ checkbashisms /work/git-local/linux.git/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc
> possible bashism in /work/git-local/linux.git/tools/testing/selftests/ftrace/test.d/ftrace/func_cpumask.tc line 18 ('function' is useless):
> if ! grep -q function available_tracers ; then
>
> Not sure why it did not like that line. Maybe my bashism check got
> confused by the key word "function"?
>
> Yep!
>
> By adding quotes around "function" it doesn't complain:
>
> if ! grep -q "function" available_tracers ; then
>
> May need to add that.
Thanks! Shuah, can I update this patch?
I'll send it asap.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2019-11-26 23:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 8:34 [BUGFIX PATCH v4 0/4] selftests/ftrace: Fix ftracetest testcases for non-function tracer case Masami Hiramatsu
2019-11-26 8:34 ` [BUGFIX PATCH v4 1/4] selftests/ftrace: Fix to check the existence of set_ftrace_filter Masami Hiramatsu
2019-11-26 17:24 ` Steven Rostedt
2019-11-26 8:34 ` [BUGFIX PATCH v4 2/4] selftests/ftrace: Fix ftrace test cases to check unsupported Masami Hiramatsu
2019-11-26 17:49 ` Steven Rostedt
2019-11-26 23:31 ` Masami Hiramatsu [this message]
2019-11-26 23:42 ` [BUGFIX PATCH v4.1 " Masami Hiramatsu
2019-11-26 23:50 ` [BUGFIX PATCH v4 " shuah
2019-11-27 2:15 ` Steven Rostedt
2019-11-26 8:34 ` [BUGFIX PATCH v4 3/4] selftests/ftrace: Do not to use absolute debugfs path Masami Hiramatsu
2019-11-26 8:34 ` [BUGFIX PATCH v4 4/4] selftests/ftrace: Fix multiple kprobe testcase Masami Hiramatsu
2019-11-26 17:37 ` [BUGFIX PATCH v4 0/4] selftests/ftrace: Fix ftracetest testcases for non-function tracer case shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127083123.0257d2c450bfd87b0691300d@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).