linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Down <chris@chrisdown.name>
To: Roman Gushchin <guro@fb.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@fb.com, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH kselftest-next 2/2] kselftests: memcg: speed up the memory.high test
Date: Tue, 3 Dec 2019 11:58:47 -0500	[thread overview]
Message-ID: <20191203165847.GB607734@chrisdown.name> (raw)
In-Reply-To: <20191202234212.4134802-2-guro@fb.com>

Roman Gushchin writes:
>After commit 0e4b01df8659 ("mm, memcg: throttle allocators when
>failing reclaim over memory.high") allocating memory over memory.high
>became very time consuming. But it's exactly what the memory.high
>test from cgroup kselftests is doing: it tries to allocate 100M with
>30M memory.high value. It takes forever to complete.
>
>In order to keep it passing (or failing) in a reasonable amount of
>time let's try to allocate only a little over 30M: 31M to be precise.
>
>With this change test_memcontrol finishes in a reasonable amount of
>time:
>  $ time ./test_memcontrol
>  ok 1 test_memcg_subtree_control
>  ok 2 test_memcg_current
>  ok 3 test_memcg_min
>  ok 4 test_memcg_low
>  ok 5 test_memcg_high
>  ok 6 test_memcg_max
>  ok 7 test_memcg_oom_events
>  ok 8 test_memcg_swap_max
>  ok 9 test_memcg_sock
>  ok 10 test_memcg_oom_group_leaf_events
>  ok 11 test_memcg_oom_group_parent_events
>  ok 12 test_memcg_oom_group_score_events
>
>  real	0m2.273s
>  user	0m0.064s
>  sys	0m0.739s
>
>Signed-off-by: Roman Gushchin <guro@fb.com>
>Cc: Chris Down <chris@chrisdown.name>
>Cc: Johannes Weiner <hannes@cmpxchg.org>

Thanks, this makes sense.

Reviewed-by: Chris Down <chris@chrisdown.name>

  reply	other threads:[~2019-12-03 16:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 23:42 [PATCH kselftest-next 1/2] kselftests: memcg: update the oom group leaf events test Roman Gushchin
2019-12-02 23:42 ` [PATCH kselftest-next 2/2] kselftests: memcg: speed up the memory.high test Roman Gushchin
2019-12-03 16:58   ` Chris Down [this message]
2019-12-03 16:57 ` [PATCH kselftest-next 1/2] kselftests: memcg: update the oom group leaf events test Chris Down

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203165847.GB607734@chrisdown.name \
    --to=chris@chrisdown.name \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).