From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F646C432C0 for ; Tue, 3 Dec 2019 16:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42CCF20803 for ; Tue, 3 Dec 2019 16:58:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="L22xBp2g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbfLCQ6s (ORCPT ); Tue, 3 Dec 2019 11:58:48 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:37222 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726190AbfLCQ6s (ORCPT ); Tue, 3 Dec 2019 11:58:48 -0500 Received: by mail-qk1-f193.google.com with SMTP id m188so4138345qkc.4 for ; Tue, 03 Dec 2019 08:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=awAZi9esbUnXwgXhwi5bh2eBiqCu026SUTMkAv+bcuk=; b=L22xBp2gKa6uy6Xb4JW/SOWjMtUgH90CP7cHfER4JiCqbsofhlGIkYBC8S714MZd0t JAc4BN2VdOXH1g5oVGh8kWYTew/jD17g0YkmUCJX94s7pIYrgAg3YB0K6+gALQ/CiJJn Jy3N4G13IuXQ5AfbjEVSd0l8y0VL9AoMYh7fI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=awAZi9esbUnXwgXhwi5bh2eBiqCu026SUTMkAv+bcuk=; b=pKCu8KiB2gquUX5vtzEY727xmtYUCTmbg3vDeJXd7HWYAViX+hslHyxbleAGyb60tI YFvKL+aBZ3sixr6/+BuaTsCSAvwJYLxfpegzSeq67xvbzSWrFyJItPDchdS+vho7/y+H bYBYVWAuv+CW4XwkYMqQIIffhE0enD+vDSK2kMQ2kiKyQSP/zXQutP7aMUFSHPRYjmdW 809DaRgzgrzhaaBQBpbZc7eMDwTqsR/T3fLjB+eqOA/FnlgkqDwrHqeqe6OsU2bzEhu0 LQDzzRXdSf48WP0cnjm1OAZtXmoqI77AlgMVsqgYhZGGiAOZCMZ+WcCfk+qohuDs6WiV NWJQ== X-Gm-Message-State: APjAAAW9u9jQGn2iRhT6cIFSLnQkPKPiWNOwonWoAQ3KyOWc9X2waZ95 GluOsMmYzDHKmtG1JfkLwkEtQA== X-Google-Smtp-Source: APXvYqzPRcP0xDwFOlYh6VQJvJ3upogxLDCfmpeKQJYYXPnQMvIQnXAR62SHl+8BMMa/0Qr4zaQT0Q== X-Received: by 2002:a37:4782:: with SMTP id u124mr6238808qka.8.1575392327688; Tue, 03 Dec 2019 08:58:47 -0800 (PST) Received: from localhost ([2620:10d:c091:500::2:49ea]) by smtp.gmail.com with ESMTPSA id y10sm1959520qky.6.2019.12.03.08.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 08:58:47 -0800 (PST) Date: Tue, 3 Dec 2019 11:58:47 -0500 From: Chris Down To: Roman Gushchin Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Johannes Weiner Subject: Re: [PATCH kselftest-next 2/2] kselftests: memcg: speed up the memory.high test Message-ID: <20191203165847.GB607734@chrisdown.name> References: <20191202234212.4134802-1-guro@fb.com> <20191202234212.4134802-2-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20191202234212.4134802-2-guro@fb.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Roman Gushchin writes: >After commit 0e4b01df8659 ("mm, memcg: throttle allocators when >failing reclaim over memory.high") allocating memory over memory.high >became very time consuming. But it's exactly what the memory.high >test from cgroup kselftests is doing: it tries to allocate 100M with >30M memory.high value. It takes forever to complete. > >In order to keep it passing (or failing) in a reasonable amount of >time let's try to allocate only a little over 30M: 31M to be precise. > >With this change test_memcontrol finishes in a reasonable amount of >time: > $ time ./test_memcontrol > ok 1 test_memcg_subtree_control > ok 2 test_memcg_current > ok 3 test_memcg_min > ok 4 test_memcg_low > ok 5 test_memcg_high > ok 6 test_memcg_max > ok 7 test_memcg_oom_events > ok 8 test_memcg_swap_max > ok 9 test_memcg_sock > ok 10 test_memcg_oom_group_leaf_events > ok 11 test_memcg_oom_group_parent_events > ok 12 test_memcg_oom_group_score_events > > real 0m2.273s > user 0m0.064s > sys 0m0.739s > >Signed-off-by: Roman Gushchin >Cc: Chris Down >Cc: Johannes Weiner Thanks, this makes sense. Reviewed-by: Chris Down