From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 234D6C2BBE2 for ; Sat, 7 Dec 2019 18:48:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBDB224673 for ; Sat, 7 Dec 2019 18:48:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kDanjmi2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbfLGSsC (ORCPT ); Sat, 7 Dec 2019 13:48:02 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:36127 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbfLGSsC (ORCPT ); Sat, 7 Dec 2019 13:48:02 -0500 Received: by mail-pl1-f196.google.com with SMTP id k20so4085387pls.3 for ; Sat, 07 Dec 2019 10:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gIYTvT9Yg0a3HYHkSd1eqhNX0DVUa1na6x4qIySAj/s=; b=kDanjmi2KTqwcxU+vWAA6MY44bNeH/m6+LJ+PXBtyz8m0/IEd5Id3ctmrutsjQlWol nzRhS9ee3BeqtPgZQwsptPbKTwka3iyzO+GMbTS5U45YPei2BeQ4m1/Obijuy1h6PjDR Fs/96o+Lq/d1RGFXUVbM7TUzvcWvzYHi/YCHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gIYTvT9Yg0a3HYHkSd1eqhNX0DVUa1na6x4qIySAj/s=; b=a+UUIk91jSsX1x0K08Vg/2ja2aPbyhZCg4T0bBmqgcdwM2bjuUJPVREy3w58kDViBp lLZU36GLV+YEQD4gFMEA3yXeqgysWsSewCimJpLSNx4CR8D5wq5zW8v/s6abD9dM8h2F QBSbm2ZymxRlMcFLsaNGNhAyz7zUc1dspHMPm9GAO/k/oAtlPLgKdAEmv1gdRgRC8GE7 hqiRmRIclZZDqgSkA4+mlCxfuLVzFcmsQ826+z1BCyjvgruqMHFeRS9VFXkQuiqS+bli 5rF4Jmn4lM9MgUf1zyjylM/XTmSbgX6PREvSGpAr4eafDLXcP+LG/EXRjTLGzwYh8UUY R4wQ== X-Gm-Message-State: APjAAAV+9vi3QO4d0vnb0v2FnExkeDBrcQED1wL+iHiHh5brOIFj3Xv5 7dn3OabtvAKYwFhM/hu5nQpNCA== X-Google-Smtp-Source: APXvYqx3yu/c68zUTI1LPwAt2andskVpfvUBqNZ+i7uTa0sh9iba5RR78nUbCHT0uaN7c89V1ukSBw== X-Received: by 2002:a17:90a:e291:: with SMTP id d17mr23575494pjz.116.1575744481553; Sat, 07 Dec 2019 10:48:01 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 3sm18140868pfi.13.2019.12.07.10.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Dec 2019 10:48:00 -0800 (PST) Date: Sat, 7 Dec 2019 10:47:59 -0800 From: Kees Cook To: SeongJae Park Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, sj38.park@gmail.com, SeongJae Park Subject: Re: [PATCH 2/2] kselftest: Support old perl versions Message-ID: <201912071047.D7BDF3DD9F@keescook> References: <20191202114221.827-1-sjpark@amazon.com> <20191202114221.827-2-sjpark@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202114221.827-2-sjpark@amazon.com> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Dec 02, 2019 at 12:42:21PM +0100, SeongJae Park wrote: > From: SeongJae Park > > On an old perl such as v5.10.1, `kselftest/prefix.pl` gives below error > message: > > Can't locate object method "autoflush" via package "IO::Handle" at kselftest/prefix.pl line 10. > > This commit fixes the error by explicitly specifying the use of the > `IO::Handle` package. > > Signed-off-by: SeongJae Park Good catch! Acked-by: Kees Cook -Kees > --- > tools/testing/selftests/kselftest/prefix.pl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/kselftest/prefix.pl b/tools/testing/selftests/kselftest/prefix.pl > index ec7e48118183..31f7c2a0a8bd 100755 > --- a/tools/testing/selftests/kselftest/prefix.pl > +++ b/tools/testing/selftests/kselftest/prefix.pl > @@ -3,6 +3,7 @@ > # Prefix all lines with "# ", unbuffered. Command being piped in may need > # to have unbuffering forced with "stdbuf -i0 -o0 -e0 $cmd". > use strict; > +use IO::Handle; > > binmode STDIN; > binmode STDOUT; > -- > 2.17.1 > -- Kees Cook