From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5770C2D0C9 for ; Thu, 12 Dec 2019 09:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BBB721655 for ; Thu, 12 Dec 2019 09:25:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="K/BGdkTb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728365AbfLLJZQ (ORCPT ); Thu, 12 Dec 2019 04:25:16 -0500 Received: from mail.skyhub.de ([5.9.137.197]:47846 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728344AbfLLJZQ (ORCPT ); Thu, 12 Dec 2019 04:25:16 -0500 Received: from zn.tnic (p200300EC2F0A5A00984E1B37A4E020FA.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:5a00:984e:1b37:a4e0:20fa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9E4F41EC0985; Thu, 12 Dec 2019 10:25:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1576142714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=+dYA8drbIsiT7giIEQe7BBpW6cQ7yCAKZaHUc/zBWRM=; b=K/BGdkTbgGNJ3oJxIP+zDsGaBijLUTL6eRRcQn81scGw+OHe8dzUUZE+q0t39gaKxHUqX+ VD4HI9lFACMrJGt79F9WU4np/Bgsd+KgljTPCLospi5QIiX4hEdaTV+g05+UjlIMz/lofV F7Prs7AFNWlxF1UddZrrXLCUK9F8y9A= Date: Thu, 12 Dec 2019 10:25:09 +0100 From: Borislav Petkov To: Sean Christopherson Cc: kbuild test robot , kbuild-all@lists.01.org, Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Tony Luck , Tony W Wang-oc , Len Brown , Shuah Khan , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-edac@vger.kernel.org, linux-pm@vger.kernel.org, linux-kselftest@vger.kernel.org, Jarkko Sakkinen Subject: Re: [PATCH v4 01/19] x86/msr-index: Clean up bit defines for IA32_FEATURE_CONTROL MSR Message-ID: <20191212092509.GB4991@zn.tnic> References: <20191128014016.4389-2-sean.j.christopherson@intel.com> <201912010347.7tMb4moN%lkp@intel.com> <20191202190633.GG4063@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191202190633.GG4063@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Mon, Dec 02, 2019 at 11:06:33AM -0800, Sean Christopherson wrote: > Argh, flat out missed this when doing search and replace. There are more. What always works reliably for me is git grep: $ git grep MSR_IA32_FEATURE_CONTROL drivers/idle/intel_idle.c:1287: rdmsrl(MSR_IA32_FEATURE_CONTROL, msr); tools/arch/x86/include/asm/msr-index.h:561:#define MSR_IA32_FEATURE_CONTROL 0x0000003a tools/power/x86/turbostat/turbostat.c:4502: if (!get_msr(base_cpu, MSR_IA32_FEATURE_CONTROL, &msr)) tools/power/x86/turbostat/turbostat.c:4503: fprintf(outf, "cpu%d: MSR_IA32_FEATURE_CONTROL: 0x%08llx (%sLocked %s)\n", tools/testing/selftests/kvm/include/x86_64/processor.h:771:#define MSR_IA32_FEATURE_CONTROL 0x0000003a tools/testing/selftests/kvm/lib/x86_64/vmx.c:162: feature_control = rdmsr(MSR_IA32_FEATURE_CONTROL); tools/testing/selftests/kvm/lib/x86_64/vmx.c:164: wrmsr(MSR_IA32_FEATURE_CONTROL, feature_control | required); those additional ones won't break the build but it is perhaps worth unifying them all since we're at it, anyway. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette