* Re: linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o)
[not found] <20200113181457.209ab4a5@canb.auug.org.au>
@ 2020-01-13 22:59 ` Randy Dunlap
2020-01-13 23:40 ` Stephen Rothwell
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2020-01-13 22:59 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, Brendan Higgins, linux-kselftest, Shuah Khan
On 1/12/20 11:14 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20200110:
>
> The kunit-next tree lost its failures.
>
on i386:
WARNING: modpost: missing MODULE_LICENSE() in drivers/base/test/property-entry-test.o
see include/linux/module.h for more information
--
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o)
2020-01-13 22:59 ` linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o) Randy Dunlap
@ 2020-01-13 23:40 ` Stephen Rothwell
2020-01-14 1:10 ` Brendan Higgins
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-01-13 23:40 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Next Mailing List, Linux Kernel Mailing List,
Brendan Higgins, linux-kselftest, Shuah Khan, Rafael J. Wysocki,
Dmitry Torokhov, Alan Maguire
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
Hi Randy,
On Mon, 13 Jan 2020 14:59:54 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> on i386:
>
> WARNING: modpost: missing MODULE_LICENSE() in drivers/base/test/property-entry-test.o
> see include/linux/module.h for more information
Sorry, I missed that yesterday.
Caused by commit
c032ace71c29 ("software node: add basic tests for property entries")
from the pm tree interacting with commit
9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
from the kunit-next tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o)
2020-01-13 23:40 ` Stephen Rothwell
@ 2020-01-14 1:10 ` Brendan Higgins
2020-01-14 16:14 ` Alan Maguire
0 siblings, 1 reply; 4+ messages in thread
From: Brendan Higgins @ 2020-01-14 1:10 UTC (permalink / raw)
To: Stephen Rothwell, KUnit Development
Cc: Randy Dunlap, Linux Next Mailing List, Linux Kernel Mailing List,
open list:KERNEL SELFTEST FRAMEWORK, Shuah Khan,
Rafael J. Wysocki, Dmitry Torokhov, Alan Maguire
+KUnit Development
+open list:KERNEL SELFTEST FRAMEWORK
On Mon, Jan 13, 2020 at 3:40 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Randy,
>
> On Mon, 13 Jan 2020 14:59:54 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > on i386:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/base/test/property-entry-test.o
> > see include/linux/module.h for more information
>
> Sorry, I missed that yesterday.
>
> Caused by commit
>
> c032ace71c29 ("software node: add basic tests for property entries")
>
> from the pm tree interacting with commit
>
> 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
>
> from the kunit-next tree.
Yes, the problem seems to be that the property-entry-test is turned on
when CONFIG_KUNIT is y or m.
From drivers/base/test/Makefile:
...
obj-$(CONFIG_KUNIT) += property-entry-test.o
It seems we can fix it just by adding the missing MODULE_LICENSE, but
I think there is a bigger question of whether we should let people do
this. Do we want to just let people have their tests run whenever
CONFIG_KUNIT is enabled? I am inclined to think no. It should be
possible for people to run their test and their test only.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o)
2020-01-14 1:10 ` Brendan Higgins
@ 2020-01-14 16:14 ` Alan Maguire
0 siblings, 0 replies; 4+ messages in thread
From: Alan Maguire @ 2020-01-14 16:14 UTC (permalink / raw)
To: Brendan Higgins
Cc: Stephen Rothwell, KUnit Development, Randy Dunlap,
Linux Next Mailing List, Linux Kernel Mailing List,
open list:KERNEL SELFTEST FRAMEWORK, Shuah Khan,
Rafael J. Wysocki, Dmitry Torokhov, Alan Maguire
On Mon, 13 Jan 2020, Brendan Higgins wrote:
> +KUnit Development
> +open list:KERNEL SELFTEST FRAMEWORK
>
> On Mon, Jan 13, 2020 at 3:40 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi Randy,
> >
> > On Mon, 13 Jan 2020 14:59:54 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> > >
> > > on i386:
> > >
> > > WARNING: modpost: missing MODULE_LICENSE() in drivers/base/test/property-entry-test.o
> > > see include/linux/module.h for more information
> >
> > Sorry, I missed that yesterday.
> >
> > Caused by commit
> >
> > c032ace71c29 ("software node: add basic tests for property entries")
> >
> > from the pm tree interacting with commit
> >
> > 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
> >
> > from the kunit-next tree.
>
> Yes, the problem seems to be that the property-entry-test is turned on
> when CONFIG_KUNIT is y or m.
>
> From drivers/base/test/Makefile:
> ...
> obj-$(CONFIG_KUNIT) += property-entry-test.o
>
> It seems we can fix it just by adding the missing MODULE_LICENSE, but
> I think there is a bigger question of whether we should let people do
> this. Do we want to just let people have their tests run whenever
> CONFIG_KUNIT is enabled? I am inclined to think no. It should be
> possible for people to run their test and their test only.
>
I agree completely, CONFIG_KUNIT is too big a switch I
think, aside from the merge issues caused here. I've posted
a patch which introduces a per-test-suite CONFIG option:
https://lore.kernel.org/lkml/1579018183-14879-1-git-send-email-alan.maguire@oracle.com/T/#u
Brendan, do let me know if you want me to amend it to add a Suggested-by
from you (didn't want to add it without your permission). Thanks!
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-14 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200113181457.209ab4a5@canb.auug.org.au>
2020-01-13 22:59 ` linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o) Randy Dunlap
2020-01-13 23:40 ` Stephen Rothwell
2020-01-14 1:10 ` Brendan Higgins
2020-01-14 16:14 ` Alan Maguire
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).