From: Masami Hiramatsu <mhiramat@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
jaswinder.singh@linaro.org, bpf@vger.kernel.org,
daniel@iogearbox.net
Subject: Re: [BUGFIX PATCH] selftests: Fix pthread link option
Date: Thu, 16 Jan 2020 07:17:50 +0900 [thread overview]
Message-ID: <20200116071750.0bde391266ea7637ee041d8c@kernel.org> (raw)
In-Reply-To: <20200115192528.kq44bg24ezsgo5hm@ast-mbp.dhcp.thefacebook.com>
On Wed, 15 Jan 2020 11:25:30 -0800
Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
> On Wed, Jan 15, 2020 at 06:16:07PM +0900, Masami Hiramatsu wrote:
> > To support pthread correctly, it is better to use -pthread
> > instead of -lpthread.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > tools/testing/selftests/bpf/Makefile | 2 +-
> > tools/testing/selftests/membarrier/Makefile | 2 +-
> > tools/testing/selftests/mqueue/Makefile | 2 +-
> > tools/testing/selftests/net/Makefile | 4 ++--
> > .../testing/selftests/powerpc/benchmarks/Makefile | 4 ++--
> > tools/testing/selftests/powerpc/dscr/Makefile | 2 +-
> > tools/testing/selftests/powerpc/mm/Makefile | 2 +-
> > tools/testing/selftests/rseq/Makefile | 2 +-
> > tools/testing/selftests/rtc/Makefile | 2 +-
> > tools/testing/selftests/seccomp/Makefile | 2 +-
> > tools/testing/selftests/timers/Makefile | 2 +-
> > tools/testing/selftests/vm/Makefile | 2 +-
> > 12 files changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> > index e2fd6f8d579c..419f58c53d12 100644
> > --- a/tools/testing/selftests/bpf/Makefile
> > +++ b/tools/testing/selftests/bpf/Makefile
> > @@ -22,7 +22,7 @@ CFLAGS += -g -Wall -O2 $(GENFLAGS) -I$(APIDIR) -I$(LIBDIR) -I$(BPFDIR) \
> > -I$(GENDIR) -I$(TOOLSDIR) -I$(CURDIR) \
> > -Dbpf_prog_load=bpf_prog_test_load \
> > -Dbpf_load_program=bpf_test_load_program
> > -LDLIBS += -lcap -lelf -lrt -lpthread
> > +LDLIBS += -lcap -lelf -lrt -pthread
>
> Please split this bit into separate patch and send it to bpf@vger targeting
> bpf-next. selftests/bpf are going through a lot of changes and I'd like to
> avoid any chance of conflicts.
OK, I'll split it.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-01-15 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 9:16 [BUGFIX PATCH] selftests: Fix pthread link option Masami Hiramatsu
2020-01-15 19:25 ` Alexei Starovoitov
2020-01-15 22:17 ` Masami Hiramatsu [this message]
2020-01-16 2:37 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116071750.0bde391266ea7637ee041d8c@kernel.org \
--to=mhiramat@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).