From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Shuah Khan <shuah@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kselftest@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH][RESEND] selftests/ftrace: Have pid filter test use instance flag
Date: Fri, 31 Jan 2020 12:32:03 +0900 [thread overview]
Message-ID: <20200131123203.5de85bfa6ccf946934963e86@kernel.org> (raw)
In-Reply-To: <20200130214527.1ce9a39e@rorschach.local.home>
On Thu, 30 Jan 2020 21:45:27 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
>
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> While running the ftracetests, the pid filter test failed because the
> instance "foo" existed, and it was using it to rerun the test under a
> instance named foo. The collision caused the test to fail as the mkdir
> failed as the name already existed.
>
> As of commit b5b77be812de7 ("selftests: ftrace: Allow some tests to be run
> in a tracing instance") all a selftest needs to do to be tested in an
> instance is to set the "instance" flag. There's no reason a selftest needs
> to create an instance to run its test in an instance directly.
>
> Remove the open coded testing in an instance for the pid filter test and
> have it set the "instance" flag instead.
>
This looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> .../selftests/ftrace/test.d/ftrace/func-filter-pid.tc | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
> index 64cfcc75e3c1..f2ee1e889e13 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-pid.tc
> @@ -1,6 +1,7 @@
> #!/bin/sh
> # SPDX-License-Identifier: GPL-2.0
> # description: ftrace - function pid filters
> +# flags: instance
>
> # Make sure that function pid matching filter works.
> # Also test it on an instance directory
> @@ -96,13 +97,6 @@ do_test() {
> }
>
> do_test
> -
> -mkdir instances/foo
> -cd instances/foo
> -do_test
> -cd ../../
> -rmdir instances/foo
> -
> do_reset
>
> exit 0
> --
> 2.20.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2020-01-31 3:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 2:45 [PATCH][RESEND] selftests/ftrace: Have pid filter test use instance flag Steven Rostedt
2020-01-31 3:32 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131123203.5de85bfa6ccf946934963e86@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).