linux-kselftest.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Al Viro" <viro@zeniv.linux.org.uk>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Dave Chinner" <david@fromorbit.com>,
	"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	"Michal Hocko" <mhocko@suse.com>,
	"Mike Kravetz" <mike.kravetz@oracle.com>,
	"Shuah Khan" <shuah@kernel.org>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Matthew Wilcox" <willy@infradead.org>,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
	"John Hubbard" <jhubbard@nvidia.com>
Subject: [PATCH v3 12/12] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage
Date: Fri, 31 Jan 2020 19:40:29 -0800	[thread overview]
Message-ID: <20200201034029.4063170-13-jhubbard@nvidia.com> (raw)
In-Reply-To: <20200201034029.4063170-1-jhubbard@nvidia.com>

It's good to have basic unit test coverage of the new FOLL_PIN
behavior. Fortunately, the gup_benchmark unit test is extremely
fast (a few milliseconds), so adding it the the run_vmtests suite
is going to cause no noticeable change in running time.

So, add two new invocations to run_vmtests:

1) Run gup_benchmark with normal get_user_pages().

2) Run gup_benchmark with pin_user_pages(). This is much like
the first call, except that it sets FOLL_PIN.

Running these two in quick succession also provide a visual
comparison of the running times, which is convenient.

The new invocations are fairly early in the run_vmtests script,
because with test suites, it's usually preferable to put the
shorter, faster tests first, all other things being equal.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 tools/testing/selftests/vm/run_vmtests | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tools/testing/selftests/vm/run_vmtests b/tools/testing/selftests/vm/run_vmtests
index a692ea828317..df6a6bf3f238 100755
--- a/tools/testing/selftests/vm/run_vmtests
+++ b/tools/testing/selftests/vm/run_vmtests
@@ -112,6 +112,28 @@ echo "NOTE: The above hugetlb tests provide minimal coverage.  Use"
 echo "      https://github.com/libhugetlbfs/libhugetlbfs.git for"
 echo "      hugetlb regression testing."
 
+echo "--------------------------------------------"
+echo "running 'gup_benchmark -U' (normal/slow gup)"
+echo "--------------------------------------------"
+./gup_benchmark -U
+if [ $? -ne 0 ]; then
+	echo "[FAIL]"
+	exitcode=1
+else
+	echo "[PASS]"
+fi
+
+echo "------------------------------------------"
+echo "running gup_benchmark -b (pin_user_pages)"
+echo "------------------------------------------"
+./gup_benchmark -b
+if [ $? -ne 0 ]; then
+	echo "[FAIL]"
+	exitcode=1
+else
+	echo "[PASS]"
+fi
+
 echo "-------------------"
 echo "running userfaultfd"
 echo "-------------------"
-- 
2.25.0


      parent reply	other threads:[~2020-02-01  3:40 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01  3:40 [PATCH v3 00/12] mm/gup: track FOLL_PIN pages John Hubbard
2020-02-01  3:40 ` [PATCH v3 01/12] mm: dump_page(): better diagnostics for compound pages John Hubbard
2020-02-03 13:16   ` Kirill A. Shutemov
2020-02-03 19:51     ` John Hubbard
2020-02-01  3:40 ` [PATCH v3 02/12] mm/gup: split get_user_pages_remote() into two routines John Hubbard
2020-02-03 13:17   ` Kirill A. Shutemov
2020-02-03 14:20   ` Jan Kara
2020-02-03 21:09     ` John Hubbard
2020-02-01  3:40 ` [PATCH v3 03/12] mm/gup: pass a flags arg to __gup_device_* functions John Hubbard
2020-02-03 13:19   ` Kirill A. Shutemov
2020-02-03 19:56     ` John Hubbard
2020-02-01  3:40 ` [PATCH v3 04/12] mm: introduce page_ref_sub_return() John Hubbard
2020-02-03 13:23   ` Kirill A. Shutemov
2020-02-03 20:03     ` John Hubbard
2020-02-01  3:40 ` [PATCH v3 05/12] mm/gup: pass gup flags to two more routines John Hubbard
2020-02-03 13:24   ` Kirill A. Shutemov
2020-02-03 14:18   ` Jan Kara
2020-02-01  3:40 ` [PATCH v3 06/12] mm/gup: require FOLL_GET for get_user_pages_fast() John Hubbard
2020-02-03 13:26   ` Kirill A. Shutemov
2020-02-03 14:18   ` Jan Kara
2020-02-01  3:40 ` [PATCH v3 07/12] mm/gup: track FOLL_PIN pages John Hubbard
2020-02-03 13:40   ` Kirill A. Shutemov
2020-02-03 21:01     ` John Hubbard
2020-02-03 14:29   ` Jan Kara
2020-02-01  3:40 ` [PATCH v3 08/12] mm/gup: page->hpage_pinned_refcount: exact pin counts for huge pages John Hubbard
2020-02-03 13:45   ` Kirill A. Shutemov
2020-02-03 14:43   ` Jan Kara
2020-02-01  3:40 ` [PATCH v3 09/12] mm: dump_page(): better diagnostics for huge pinned pages John Hubbard
2020-02-03 13:46   ` Kirill A. Shutemov
2020-02-03 14:44   ` Jan Kara
2020-02-01  3:40 ` [PATCH v3 10/12] mm/gup: /proc/vmstat: pin_user_pages (FOLL_PIN) reporting John Hubbard
2020-02-03 13:53   ` Kirill A. Shutemov
2020-02-03 21:04     ` John Hubbard
2020-02-03 21:30       ` Kirill A. Shutemov
2020-02-03 21:34         ` John Hubbard
2020-02-03 23:16           ` John Hubbard
2020-02-03 23:43             ` John Hubbard
2020-02-01  3:40 ` [PATCH v3 11/12] mm/gup_benchmark: support pin_user_pages() and related calls John Hubbard
2020-02-03 13:58   ` Kirill A. Shutemov
2020-02-03 21:17     ` John Hubbard
2020-02-03 21:55       ` Kirill A. Shutemov
2020-02-03 22:07         ` John Hubbard
2020-02-01  3:40 ` John Hubbard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200201034029.4063170-13-jhubbard@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=kirill@shutemov.name \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=shuah@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).