From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alan Maguire <alan.maguire@oracle.com>,
shuah@kernel.org, mingo@redhat.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
naveen.n.rao@linux.vnet.ibm.com, colin.king@canonical.com
Subject: Re: [PATCH 1/2] ftrace/selftests: workaround cgroup RT scheduling issues
Date: Mon, 10 Feb 2020 17:18:01 -0500 [thread overview]
Message-ID: <20200210171801.521e5faa@gandalf.local.home> (raw)
In-Reply-To: <20200207151456.4177c8974b779a45520b93d7@kernel.org>
On Fri, 7 Feb 2020 15:14:56 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> On Thu, 6 Feb 2020 15:09:19 +0000
> Alan Maguire <alan.maguire@oracle.com> wrote:
>
> > wakeup_rt.tc and wakeup.tc tests in tracers/ subdirectory
> > fail due to the chrt command returning:
> >
> > chrt: failed to set pid 0's policy: Operation not permitted.
> >
> > To work around this, temporarily disable grout RT scheduling
> > during ftracetest execution. Restore original value on
> > test run completion. With these changes in place, both
> > tests consistently pass.
>
> OK, this looks good to me.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
>
> Thanks!
>
> >
> > Fixes: c575dea2c1a5 ("selftests/ftrace: Add wakeup_rt tracer testcase")
> > Fixes: c1edd060b413 ("selftests/ftrace: Add wakeup tracer testcase")
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > ---
> > tools/testing/selftests/ftrace/ftracetest | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
> > index 063ecb2..3207bbf 100755
> > --- a/tools/testing/selftests/ftrace/ftracetest
> > +++ b/tools/testing/selftests/ftrace/ftracetest
> > @@ -29,8 +29,26 @@ err_ret=1
> > # kselftest skip code is 4
> > err_skip=4
> >
> > +# cgroup RT scheduling prevents chrt commands from succeeding, which
> > +# induces failures in test wakeup tests. Disable for the duration of
> > +# the tests.
> > +sched_rt_runtime=$(sysctl -n kernel.sched_rt_runtime_us)
>
> OK, but can you
??
Masami?
-- Steve
>
> > +
> > +set_sysctl() {
> > + sysctl -qw ${1}=${2} >/dev/null 2>&1
> > +}
> > +
next prev parent reply other threads:[~2020-02-10 22:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 15:09 [PATCH 0/2] ftrace/selftests: clean up failure cases Alan Maguire
2020-02-06 15:09 ` [PATCH 1/2] ftrace/selftests: workaround cgroup RT scheduling issues Alan Maguire
2020-02-07 6:14 ` Masami Hiramatsu
2020-02-10 22:18 ` Steven Rostedt [this message]
2020-02-10 22:53 ` Masami Hiramatsu
2020-02-06 15:09 ` [PATCH 2/2] ftrace/selftest: absence of modules/programs should trigger unsupported errors Alan Maguire
2020-02-07 4:43 ` Masami Hiramatsu
2020-02-07 8:27 ` Alan Maguire
2020-02-07 8:50 ` Masami Hiramatsu
2020-02-19 9:55 ` Alan Maguire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200210171801.521e5faa@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alan.maguire@oracle.com \
--cc=colin.king@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).