From: SeongJae Park <sjpark@amazon.com>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: SeongJae Park <sjpark@amazon.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SeongJae Park <sjpark@amazon.de>
Subject: Re: Re: [PATCH] docs/kunit/start: Use '_KUNIT_TEST' config name suffix
Date: Thu, 20 Feb 2020 08:38:29 +0100 [thread overview]
Message-ID: <20200220073829.18382-1-sjpark@amazon.com> (raw)
In-Reply-To: <CAFd5g444shArgbdwaCdM3VBb9c7M1s7BJ5Dho7KEBU_fCsaJOw@mail.gmail.com> (raw)
On Wed, 19 Feb 2020 14:16:03 -0800 Brendan Higgins <brendanhiggins@google.com> wrote:
> Sorry, I didn't see this until now.
Even I also almost forgot this.
>
> On Mon, Jan 27, 2020 at 7:32 AM <sjpark@amazon.com> wrote:
> >
> > From: SeongJae Park <sjpark@amazon.de>
> >
> > It is recommended to use '_KUNIT_TEST' config name suffix for kunit
> > tests but the example is using only '_TEST' suffix. This commit fixes
> > it to also use '_KUNIT_TEST' suffix.
> >
> > Signed-off-by: SeongJae Park <sjpark@amazon.de>
>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Thanks for finding this! :D
Thanks,
SeongJae Park
>
> Thanks!
>
next prev parent reply other threads:[~2020-02-20 7:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 1:59 [PATCH] kunit/kunit_kernel: Rebuild .config if .kunitconfig is modified sj38.park
2020-01-27 15:32 ` [PATCH] docs/kunit/start: Use '_KUNIT_TEST' config name suffix sjpark
2020-02-19 22:16 ` Brendan Higgins
2020-02-20 7:38 ` SeongJae Park [this message]
2020-01-28 0:02 ` [PATCH] kunit/kunit_kernel: Rebuild .config if .kunitconfig is modified Brendan Higgins
2020-01-28 6:03 ` SeongJae Park
2020-02-05 0:46 ` Brendan Higgins
2020-02-05 2:14 ` SeongJae Park
2020-02-05 17:58 ` David Gow
2020-02-05 20:00 ` Brendan Higgins
2020-02-05 22:09 ` Russell Currey
2020-03-13 15:45 ` shuah
2020-02-04 6:41 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220073829.18382-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=brendanhiggins@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).