From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6C0C11D00 for ; Thu, 20 Feb 2020 07:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC30D2465D for ; Thu, 20 Feb 2020 07:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582184835; bh=gPFYPlPnP/EO0JNRRO6YxcBxUsp8SOzVZcqRWL9kXvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nIU6c6neU7lpciFawyBChdHuLDrABBJLOYvWr9NY++sFRWzIGWaluscjJ/raF42ay h+gVi5nBdrqeSTyl0fPt4yWpN12wZ9tOWe/pdpY+vbgraAm9T1AhQlx/2HMeso3jFP kqRFCAqBjGDQCezRQcl/LcRLaSwTM2Zw1P1XLj14= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbgBTHrO (ORCPT ); Thu, 20 Feb 2020 02:47:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:59230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbgBTHrO (ORCPT ); Thu, 20 Feb 2020 02:47:14 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6532208C4; Thu, 20 Feb 2020 07:47:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582184833; bh=gPFYPlPnP/EO0JNRRO6YxcBxUsp8SOzVZcqRWL9kXvg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=USNKR+BT0TGhAlcJQyt5OOIbt6HU5RZS60UVLaL2YxTd4Bgkx5WIfj0yUxLkdbNvU 4JSWh9j1JqzPu708h6CS8Ibfz0EqV6kyXNomJDv2xlfDrcK2b260E89Rmr+nNsAvP6 sQSd82XThSBAEqjFkpi1wMEWdk9jvIB9+QaRtKtA= Date: Thu, 20 Feb 2020 08:47:11 +0100 From: Greg Kroah-Hartman To: Scott Branden Cc: Luis Chamberlain , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , Desmond Yan , James Hu Subject: Re: [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver Message-ID: <20200220074711.GA3261162@kroah.com> References: <20200220004825.23372-1-scott.branden@broadcom.com> <20200220004825.23372-7-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220004825.23372-7-scott.branden@broadcom.com> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Feb 19, 2020 at 04:48:24PM -0800, Scott Branden wrote: > Add Broadcom VK driver offload engine. > This driver interfaces to the VK PCIe offload engine to perform > should offload functions as video transcoding on multiple streams > in parallel. VK device is booted from files loaded using > request_firmware_into_buf mechanism. After booted card status is updated > and messages can then be sent to the card. > Such messages contain scatter gather list of addresses > to pull data from the host to perform operations on. Why is this a tty driver? Have you worked with the V4L developers to tie this into the proper in-kernel apis for this type of functionality? Using a tty driver seems like the totally incorrect way to do this, what am I missing? Also, do not make up random error values, you return "-1" a lot here, that is not ok. Please fix up to return the correct -Ewhatever values instead. thanks, greg k-h