From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-integrity@vger.kernel.org,
Nikita Sobolev <Nikita.Sobolev@synopsys.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/tpm: Fix runtime error
Date: Sun, 12 Apr 2020 17:18:02 +0300 [thread overview]
Message-ID: <20200412141802.GA70976@linux.intel.com> (raw)
In-Reply-To: <20200412141118.70688-1-jarkko.sakkinen@linux.intel.com>
On Sun, Apr 12, 2020 at 05:11:17PM +0300, Jarkko Sakkinen wrote:
> There is some random clutter in test_smoke.sh:
>
> ./test_smoke.sh: line 3: self.flags: command not found
>
> Remove it.
>
> Fixes: b32694cd0724 ("Kernel selftests: tpm2: check for tpm support")
> Cc: Nikita Sobolev <Nikita.Sobolev@synopsys.com>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Instead we should apply a revert to the original patch and Nikita could
refine it. Have additional questions e.g. why the constant is declared
instead of just exit 4? The commit message long description also fails
to document any sane reasoning for anything.
It is not enough to response the reasoning to me here. It needs to be
in the commit log. This is terrible.
It is obvious there has not been any kind of sane review process in
place.
/Jarkko
next prev parent reply other threads:[~2020-04-12 14:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 14:11 [PATCH] selftests/tpm: Fix runtime error Jarkko Sakkinen
2020-04-12 14:18 ` Jarkko Sakkinen [this message]
2020-05-10 18:44 ` Nikita Sobolev
2020-05-14 0:07 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200412141802.GA70976@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Nikita.Sobolev@synopsys.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).