From: Masami Hiramatsu <mhiramat@kernel.org>
To: shuah <shuah@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Li Philip <philip.li@intel.com>,
Liu Yiding <yidingx.liu@intel.com>,
skhan@linuxfoundation.org
Subject: Re: [PATCH 2/3] selftests/ftrace: Pick only the first kprobe event to test
Date: Sat, 2 May 2020 12:05:37 +0900 [thread overview]
Message-ID: <20200502120537.cfa3cdc1d898a12dc0c15471@kernel.org> (raw)
In-Reply-To: <7751734b-83f1-bf14-9d8e-9092b0b7be3e@kernel.org>
On Fri, 1 May 2020 09:38:59 -0600
shuah <shuah@kernel.org> wrote:
> On 5/1/20 8:17 AM, Steven Rostedt wrote:
> > On Fri, 1 May 2020 22:37:51 +0900
> > Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> >> Since the kprobe/kprobe_args_type.tc reads out all event logs
> >> from the trace buffer, the test can fail if there is another
> >> fork event happens.
> >> Use head command to pick only the first kprobe event from
> >> the trace buffer to test the argument types.
> >>
> >> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> >> ---
> >> .../ftrace/test.d/kprobe/kprobe_args_type.tc | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_type.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_type.tc
> >> index 1bcb67dcae26..81490ecaaa92 100644
> >> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_type.tc
> >> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_type.tc
> >> @@ -38,7 +38,7 @@ for width in 64 32 16 8; do
> >> echo 0 > events/kprobes/testprobe/enable
> >>
> >> : "Confirm the arguments is recorded in given types correctly"
> >> - ARGS=`grep "testprobe" trace | sed -e 's/.* arg1=\(.*\) arg2=\(.*\) arg3=\(.*\) arg4=\(.*\)/\1 \2 \3 \4/'`
> >> + ARGS=`grep "testprobe" trace | head -n 1 | sed -e 's/.* arg1=\(.*\) arg2=\(.*\) arg3=\(.*\) arg4=\(.*\)/\1 \2 \3 \4/'`
> >> check_types $ARGS $width
> >>
> >> : "Clear event for next loop"
> >
> > I think I've manually added this exact change to my tests to keep it from
> > failing.
> >
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
>
> Does this conflict with:
>
> Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
> Date: Tue Apr 7 14:34:19 2020 +0800
>
> selftests/ftrace: Check the first record for kprobe_args_type.tc
>
> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=f0c0d0cf590f71b2213b29a7ded2cde3d0a1a0ba
>
> I went into mainline yesterday in my rc4 pull request.
>
> Exact change it appears.
>
> diff --git
> a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_type.tc
> b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_type.tc
> index 1bcb67dcae26..81490ecaaa92 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_type.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_type.tc
> @@ -38,7 +38,7 @@ for width in 64 32 16 8; do
> echo 0 > events/kprobes/testprobe/enable
>
> : "Confirm the arguments is recorded in given types correctly"
> - ARGS=`grep "testprobe" trace | sed -e 's/.* arg1=\(.*\) arg2=\(.*\)
> arg3=\(.*\) arg4=\(.*\)/\1 \2 \3 \4/'`
> + ARGS=`grep "testprobe" trace | head -n 1 | sed -e 's/.* arg1=\(.*\)
> arg2=\(.*\) arg3=\(.*\) arg4=\(.*\)/\1 \2 \3 \4/'`
> check_types $ARGS $width
>
> : "Clear event for next loop"
Oops, yes, please drop this patch.
Thank you,
>
> thanks,
> -- Shuah
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-05-02 3:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 13:37 [PATCH 0/3] selftests/ftrace: Fix ftracetest testcases for dash, etc Masami Hiramatsu
2020-05-01 13:37 ` [PATCH 1/3] selftests/ftrace: Make XFAIL green color Masami Hiramatsu
2020-05-01 14:15 ` Steven Rostedt
2020-05-01 13:37 ` [PATCH 2/3] selftests/ftrace: Pick only the first kprobe event to test Masami Hiramatsu
2020-05-01 14:17 ` Steven Rostedt
2020-05-01 15:38 ` shuah
2020-05-01 16:20 ` Steven Rostedt
2020-05-01 16:30 ` Shuah Khan
2020-05-02 3:05 ` Masami Hiramatsu [this message]
2020-05-01 13:38 ` [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo Masami Hiramatsu
2020-05-01 14:19 ` Steven Rostedt
2020-05-02 3:08 ` Masami Hiramatsu
2020-05-07 13:12 ` Steven Rostedt
2020-05-07 15:50 ` Masami Hiramatsu
2020-05-07 17:25 ` Steven Rostedt
2020-05-07 20:32 ` Zanussi, Tom
2020-05-08 7:11 ` Masami Hiramatsu
2020-05-07 6:45 ` Xiao Yang
2020-05-07 9:15 ` Masami Hiramatsu
2020-05-11 7:22 ` Xiao Yang
2020-05-11 9:27 ` Masami Hiramatsu
2020-05-11 10:34 ` David Laight
2020-05-11 12:01 ` [PATCH] selftests/ftrace: Use /bin/echo for backslash included command Masami Hiramatsu
2020-05-11 12:19 ` Andreas Schwab
2020-05-11 13:36 ` [PATCH v2] selftests/ftrace: Use printf " Masami Hiramatsu
2020-05-11 13:38 ` Masami Hiramatsu
2020-05-11 13:46 ` David Laight
2020-05-11 14:05 ` Masami Hiramatsu
2020-05-11 14:59 ` David Laight
2020-05-11 20:28 ` Steven Rostedt
2020-05-11 13:42 ` Andreas Schwab
2020-05-11 13:58 ` Masami Hiramatsu
2020-05-25 9:59 ` Masami Hiramatsu
2020-05-28 16:24 ` Shuah Khan
2020-05-07 9:22 ` [PATCH 3/3] selftests/ftrace: Use /bin/echo instead of built-in echo Andreas Schwab
2020-05-07 15:52 ` Masami Hiramatsu
2020-05-01 14:21 ` [PATCH 0/3] selftests/ftrace: Fix ftracetest testcases for dash, etc Steven Rostedt
2020-05-01 14:28 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200502120537.cfa3cdc1d898a12dc0c15471@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=philip.li@intel.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tom.zanussi@linux.intel.com \
--cc=yidingx.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).