From: David Miller <davem@davemloft.net>
To: vladbu@mellanox.com
Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
shuah@kernel.org, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
dcaratti@redhat.com, marcelo.leitner@gmail.com
Subject: Re: [PATCH RESEND net-next] selftests: fix flower parent qdisc
Date: Thu, 14 May 2020 12:49:54 -0700 (PDT) [thread overview]
Message-ID: <20200514.124954.1909205796405577142.davem@davemloft.net> (raw)
In-Reply-To: <20200514063552.26678-1-vladbu@mellanox.com>
From: Vlad Buslov <vladbu@mellanox.com>
Date: Thu, 14 May 2020 09:35:52 +0300
> Flower tests used to create ingress filter with specified parent qdisc
> "parent ffff:" but dump them on "ingress". With recent commit that fixed
> tcm_parent handling in dump those are not considered same parent anymore,
> which causes iproute2 tc to emit additional "parent ffff:" in first line of
> filter dump output. The change in output causes filter match in tests to
> fail.
>
> Prevent parent qdisc output when dumping filters in flower tests by always
> correctly specifying "ingress" parent both when creating and dumping
> filters.
>
> Fixes: a7df4870d79b ("net_sched: fix tcm_parent in tc filter dump")
> Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Applied, thanks.
prev parent reply other threads:[~2020-05-14 19:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 6:35 [PATCH RESEND net-next] selftests: fix flower parent qdisc Vlad Buslov
2020-05-14 19:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514.124954.1909205796405577142.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=jhs@mojatatu.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).