From: Kees Cook <keescook@chromium.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Shuah Khan <shuah@kernel.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg
Date: Sat, 27 Jun 2020 08:52:50 -0700 [thread overview]
Message-ID: <202006270849.7190A26@keescook> (raw)
In-Reply-To: <87k0zsbubg.fsf@mpe.ellerman.id.au>
On Sat, Jun 27, 2020 at 09:51:31PM +1000, Michael Ellerman wrote:
> Kees Cook <keescook@chromium.org> writes:
> > Instead of full GNU diff (which smaller boot environments may not have),
> > use "comm" which is more available.
>
> Although using "comm" requires CONFIG_PRINTK_TIME=y doesn't it?
No, it doesn't seem to. "comm" doesn't carry about the line prefixes.
AIUI, the only reason for a mention of "sort" is because of how "comm"
does its line pairing. i.e. as soon as it goes out of sync, it starts
accounting for the disjunction between files. But that's exactly what we
want it doing, and the prefix doesn't matter.
--
Kees Cook
next prev parent reply other threads:[~2020-06-27 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 20:59 [PATCH] selftests/lkdtm: Use "comm" instead of "diff" for dmesg Kees Cook
2020-06-27 11:51 ` Michael Ellerman
2020-06-27 15:52 ` Kees Cook [this message]
2020-06-29 5:50 ` Michael Ellerman
2020-06-30 18:53 ` Joe Lawrence
2020-09-09 19:49 ` Kees Cook
2020-09-09 20:29 ` Joe Lawrence
2020-09-09 21:12 ` Kees Cook
2020-09-09 20:49 ` Shuah Khan
2020-09-09 21:18 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006270849.7190A26@keescook \
--to=keescook@chromium.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=naresh.kamboju@linaro.org \
--cc=pmladek@suse.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).