From: Petr Mladek <pmladek@suse.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Anders Roxell <anders.roxell@linaro.org>,
Sami Tolvanen <samitolvanen@google.com>,
Brendan Higgins <brendanhiggins@google.com>,
"David S. Miller" <davem@davemloft.net>,
Haren Myneni <haren@us.ibm.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jiri Kosina <jikos@kernel.org>,
Joe Lawrence <joe.lawrence@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Miroslav Benes <mbenes@suse.cz>, Tal Gilboa <talgi@mellanox.com>,
kunit-dev@googlegroups.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
live-patching@vger.kernel.org
Subject: Re: [PATCH v2 2/2] kbuild: trace functions in subdirectories of lib/
Date: Wed, 8 Jul 2020 08:52:23 +0200 [thread overview]
Message-ID: <20200708065223.GA11164@alley> (raw)
In-Reply-To: <20200707092117.963394-2-masahiroy@kernel.org>
On Tue 2020-07-07 18:21:17, Masahiro Yamada wrote:
> ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE)
>
> exists here in sub-directories of lib/ to keep the behavior of
> commit 2464a609ded0 ("ftrace: do not trace library functions").
>
> Since that commit, not only the objects in lib/ but also the ones in
> the sub-directories are excluded from ftrace (although the commit
> description did not explicitly mention this).
>
> However, most of library functions in sub-directories are not so hot.
> Re-add them to ftrace.
>
> Going forward, only the objects right under lib/ will be excluded.
> diff --git a/lib/livepatch/Makefile b/lib/livepatch/Makefile
> index 9abdf615b088..295b94bff370 100644
> --- a/lib/livepatch/Makefile
> +++ b/lib/livepatch/Makefile
> @@ -2,8 +2,6 @@
> #
> # Makefile for livepatch test code.
>
> -ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE)
> -
> obj-$(CONFIG_TEST_LIVEPATCH) += test_klp_atomic_replace.o \
> test_klp_callbacks_demo.o \
> test_klp_callbacks_demo2.o \
With this change it might be possible to remove also the last few
lines that explicitly added $(CC_FLAGS_FTRACE) for two test modules.
The two modules really needed these flags. But they are fine also
for the other modules.
We could do this later as a followup patch but it would be nice
to do so here.
Best Regards,
Petr
PS: BTW: The livepatch selftests fail in Linus's master now. But it
seems to be for another reason. I am going to dig into it.
next prev parent reply other threads:[~2020-07-08 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 9:21 [PATCH v2 1/2] kbuild: introduce ccflags-remove-y and asflags-remove-y Masahiro Yamada
2020-07-07 9:21 ` [PATCH v2 2/2] kbuild: trace functions in subdirectories of lib/ Masahiro Yamada
2020-07-07 16:02 ` Steven Rostedt
2020-07-22 2:08 ` Masahiro Yamada
2020-07-22 20:49 ` Steven Rostedt
2020-07-08 6:52 ` Petr Mladek [this message]
2020-07-08 9:23 ` Petr Mladek
2020-07-22 2:10 ` Masahiro Yamada
2020-07-07 19:58 ` [PATCH v2 1/2] kbuild: introduce ccflags-remove-y and asflags-remove-y Brendan Higgins
2020-07-07 21:25 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708065223.GA11164@alley \
--to=pmladek@suse.com \
--cc=anders.roxell@linaro.org \
--cc=brendanhiggins@google.com \
--cc=davem@davemloft.net \
--cc=haren@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=talgi@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).