From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5B2CC433E1 for ; Wed, 15 Jul 2020 07:03:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6D792067D for ; Wed, 15 Jul 2020 07:03:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728180AbgGOHDh (ORCPT ); Wed, 15 Jul 2020 03:03:37 -0400 Received: from [195.135.220.15] ([195.135.220.15]:60618 "EHLO mx2.suse.de" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1726212AbgGOHDh (ORCPT ); Wed, 15 Jul 2020 03:03:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B84BDAD1A; Wed, 15 Jul 2020 07:03:38 +0000 (UTC) Date: Wed, 15 Jul 2020 09:03:35 +0200 From: Petr Mladek To: Kamalesh Babulal , Josh Poimboeuf , Jiri Kosina , Miroslav Benes Cc: Joe Lawrence , Shuah Khan , live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/livepatch: adopt to newer sysctl error format Message-ID: <20200715070335.GT4751@alley> References: <20200714091030.1611-1-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200714091030.1611-1-pmladek@suse.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Tue 2020-07-14 11:10:30, Petr Mladek wrote: > With procfs v3.3.16, the sysctl command doesn't print the set key and > value on error. This change breaks livepatch selftest test-ftrace.sh, > that tests the interaction of sysctl ftrace_enabled: > > Make it work with all sysctl versions using '-q' option. > > Explicitly print the final status on success so that it can be verified > in the log. The error message is enough on failure. > > Reported-by: Kamalesh Babulal > Signed-off-by: Petr Mladek The patch is commited in livepatch.git, branch for-5.9/selftests-cleanup. Best Regards, Petr