From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DD0C433DF for ; Thu, 16 Jul 2020 20:29:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 052F7207E8 for ; Thu, 16 Jul 2020 20:29:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725928AbgGPU3k (ORCPT ); Thu, 16 Jul 2020 16:29:40 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:39027 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbgGPU3k (ORCPT ); Thu, 16 Jul 2020 16:29:40 -0400 Received: from ip5f5af08c.dynamic.kabel-deutschland.de ([95.90.240.140] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jwAVc-0007Lm-LN; Thu, 16 Jul 2020 20:29:36 +0000 Date: Thu, 16 Jul 2020 22:29:35 +0200 From: Christian Brauner To: Kees Cook Cc: Gabriel Krisman Bertazi , Andy Lutomirski , Matthew Wilcox , tglx@linutronix.de, linux-kernel@vger.kernel.org, kernel@collabora.com, gofmanp@gmail.com, linux-api@vger.kernel.org, x86@kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, jannh@google.com Subject: Re: [PATCH v4 0/2] Syscall User Redirection Message-ID: <20200716202935.yorxrz2om67r366x@wittgenstein> References: <20200716193141.4068476-1-krisman@collabora.com> <202007161300.7452A2C5@keescook> <20200716202234.wryj7pj7zmwcrxxx@wittgenstein> <202007161324.E75E01B@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202007161324.E75E01B@keescook> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Jul 16, 2020 at 01:25:43PM -0700, Kees Cook wrote: > On Thu, Jul 16, 2020 at 10:22:34PM +0200, Christian Brauner wrote: > > On Thu, Jul 16, 2020 at 01:04:38PM -0700, Kees Cook wrote: > > > On Thu, Jul 16, 2020 at 03:31:39PM -0400, Gabriel Krisman Bertazi wrote: > > > > This is v4 of Syscall User Redirection. The implementation itself is > > > > not modified from v3, it only applies the latest round of reviews to the > > > > selftests. > > > > > > > > __NR_syscalls is not really exported in header files other than > > > > asm-generic for every architecture, so it felt safer to optionally > > > > expose it with a fallback to a high value. > > > > > > > > Also, I didn't expose tests for PR_GET as that is not currently > > > > implemented. If possible, I'd have it supported by a future patchset, > > > > since it is not immediately necessary to support this feature. > > > > > > Thanks! That all looks good to me. > > > > Don't have any problem with this but did this ever get exposure on > > linux-api? This is the first time I see this pop up. > > I thought I'd added it to CC in the past, but that might have been other > recent unrelated threads. Does this need a full repost there too, you > think? Nah, wasn't my intention to force a repost. Seems that several people have looked this over. :) Just curious why it didn't get to linux-api and we know quite some people who only do look at linux-api (for sanity). :) Christian