From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C03E6C433DF for ; Wed, 22 Jul 2020 19:45:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C94D20714 for ; Wed, 22 Jul 2020 19:45:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Rvheysi+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726564AbgGVTpN (ORCPT ); Wed, 22 Jul 2020 15:45:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726462AbgGVTpN (ORCPT ); Wed, 22 Jul 2020 15:45:13 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE405C0619E1 for ; Wed, 22 Jul 2020 12:45:12 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id k71so2058708pje.0 for ; Wed, 22 Jul 2020 12:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nWRg8habjmwUq/aSOIs5oJ/PIMDu1J2enCdaZpnqjtI=; b=Rvheysi+PYCBmuMOpzRtK6Oze6jqgkcolfrm0c2G06ZfucZ7GN0cNoCE00nMt2FymF bAeDzTaaaM7LEWiVN/ByX7unj0u0rupZmXTT/6dfvTS1tdTa5UQ1K1x+SZPtoxk/hjTq +c06od/fOU5c0Kj4Evbb/bGw1U4B0Ub2f8v6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nWRg8habjmwUq/aSOIs5oJ/PIMDu1J2enCdaZpnqjtI=; b=SDtfFTOWh6QEO8wyLpp88GpCFBJHZvSF4Jf0IQlOfwDFRNMLUjVZAOXE4WqqghLbM7 QacXzWQaJhF2bgcwVoYIUNwSjabq0jH8XupnsHZFDY7wHNzUF2pleE95Bb1vqVRbtqDx kBOpFAySzEBzu+X5BamrwFZJygoB6YyOZweTyb4pALShF3htRC6KW6hpEsdIlvAyvMnV Vfw6Sy9z4LhfqyYahZIHwOYJHwJmHbiPmwtjL9AL6k7Mc002sS5J2PpTXJlZDQgTvIkC GMYF3aPh9RmnzG9RHymn59pMiHEBFR5hsjCCBC/3Td1Jebzcn94XO2ds0FFtQMWCiQ6z 0I5A== X-Gm-Message-State: AOAM531YK1+RoqisToLtVm8jngMVJYaF8A2tXT02ucwqeiXouMoj0fuJ xIS5X2yHWr0z3is1tDqlawCSKA== X-Google-Smtp-Source: ABdhPJxp0OPbK17T/FisysBhZk0+gpPejV6bgMq7eWQizEQTOQ0sgf0Q3VWKJW6xGgrHmxb3WQ5IuA== X-Received: by 2002:a17:90a:a50d:: with SMTP id a13mr837453pjq.95.1595447112507; Wed, 22 Jul 2020 12:45:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t29sm432106pfq.50.2020.07.22.12.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2020 12:45:11 -0700 (PDT) Date: Wed, 22 Jul 2020 12:45:10 -0700 From: Kees Cook To: Vitor Massaru Iha Cc: KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Brendan Higgins , David Gow , Shuah Khan , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v3] lib: Convert test_user_copy to KUnit test Message-ID: <202007221244.4E3C9E45@keescook> References: <20200721174654.72132-1-vitor@massaru.org> <202007211207.5BAA9D8D@keescook> <202007211911.666E080@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Jul 22, 2020 at 03:29:27PM -0300, Vitor Massaru Iha wrote: > On Tue, Jul 21, 2020 at 11:12 PM Kees Cook wrote: > > > > On Tue, Jul 21, 2020 at 07:19:12PM -0300, Vitor Massaru Iha wrote: > > > When you talk about end-of-test summary, is it what is written in > > > dmesg and not the kunit-tool? > > > > Right, if I build this as a module and do "modprobe user_copy_kunit", > > what will show up in dmesg? > > No, It doesn't. I'll put the messages again. Would it be possible to add that behavior to the core KUnit output? Then all module-based tests would include a summary line? -- Kees Cook