From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 881B8C433E0 for ; Sat, 25 Jul 2020 10:07:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 63518206F6 for ; Sat, 25 Jul 2020 10:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595671621; bh=DXKTp7F9hVX/ZMZ3cMvlM+waZARTWo/ANSvb7sYnEho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0CMOUh3lInZnugFFEaCfdulRPExJdzbdDt92CZCV0mrCv+67hwQ7fAgsLl2dgfqEg hYJ71g1iPwvr5zQff+O3Te1O8z8PvdvONu0p35/yqgCWMhf9zn3jST78OVeKTsMJqN UC+oykqAjkhQjWjcVkoySNYaOVjluH6AVPxubdSA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726837AbgGYKHB (ORCPT ); Sat, 25 Jul 2020 06:07:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:47284 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726572AbgGYKHA (ORCPT ); Sat, 25 Jul 2020 06:07:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F3EA3206D7; Sat, 25 Jul 2020 10:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595671620; bh=DXKTp7F9hVX/ZMZ3cMvlM+waZARTWo/ANSvb7sYnEho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=csoeNhZKhfy/PaKNHDzhb6fewTblIs59HKYmONeMkW7H74jifgwJGAr6lPRX4Vxlw Z7+gvZk8JV6ESWik0r9XZf9nTKM+BHkr7Qjq2D4AQsu3HRqL+SabERQUdkBlDdSpup e4N/tbzlVOUSYcVU4+kHmshhXryc9aBAsUBwgFMM= Date: Sat, 25 Jul 2020 12:07:00 +0200 From: Greg Kroah-Hartman To: Kees Cook Cc: stable@vger.kernel.org, Scott Branden , Mimi Zohar , Luis Chamberlain , Jessica Yu , SeongJae Park , KP Singh , linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/19] firmware_loader: EFI firmware loader must handle pre-allocated buffer Message-ID: <20200725100700.GB1073708@kroah.com> References: <20200724213640.389191-1-keescook@chromium.org> <20200724213640.389191-4-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200724213640.389191-4-keescook@chromium.org> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Fri, Jul 24, 2020 at 02:36:24PM -0700, Kees Cook wrote: > The EFI platform firmware fallback would clobber any pre-allocated > buffers. Instead, correctly refuse to reallocate when too small (as > already done in the sysfs fallback), or perform allocation normally > when needed. > > Fixes: e4c2c0ff00ec ("firmware: Add new platform fallback mechanism and firm ware_request_platform()") "firmware_request_platform()" :)