From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vitor Massaru Iha <vitor@massaru.org>
Cc: kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, brendanhiggins@google.com,
skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
gregkh@linuxfoundation.org, tglx@linutronix.de,
fkostenzer@live.at, geert@linux-m68k.org,
paul.gortmaker@windriver.com, akpm@linux-foundation.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH v2] lib: kunit: Convert test_sort to KUnit test
Date: Wed, 29 Jul 2020 22:19:48 +0300 [thread overview]
Message-ID: <20200729191948.GZ3703480@smile.fi.intel.com> (raw)
In-Reply-To: <20200729191151.476368-1-vitor@massaru.org>
On Wed, Jul 29, 2020 at 04:11:51PM -0300, Vitor Massaru Iha wrote:
> This adds the conversion of the test_sort.c to KUnit test.
>
> Please apply this commit first (linux-kselftest/kunit-fixes):
> 3f37d14b8a3152441f36b6bc74000996679f0998 kunit: kunit_config: Fix parsing of CONFIG options with space
Looks like you mixed up commit message and changelog / comments.
> Code Style Documentation: [0]
>
> Fix these warnings Reported-by lkp@intel.com
>
> WARNING: modpost: vmlinux.o(.data+0x4fc70): Section mismatch in reference from the variable sort_test_cases to the variable .init.text:sort_test
> The variable sort_test_cases references
> the variable __init sort_test
> If the reference is valid then annotate the
> variable with or __refdata (see linux/init.h) or name the variable
>
> WARNING: modpost: lib/sort_kunit.o(.data+0x11c): Section mismatch in reference from the variable sort_test_cases to the function .init.text:sort_test()
> The variable sort_test_cases references
> the function __init sort_test()
> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: [0] https://lore.kernel.org/linux-kselftest/20200620054944.167330-1-davidgow@google.com/T/#u
This should be in different order: Link, Reported-by, SoB.
Also [0] is unnecessary
> lib/{test_sort.c => sort_kunit.c} | 31 +++++++++++++++----------------
Still opened question why kunit is a suffix? Can't we leave same name? Can't we
do it rather prefix?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-29 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 19:11 [PATCH v2] lib: kunit: Convert test_sort to KUnit test Vitor Massaru Iha
2020-07-29 19:19 ` Andy Shevchenko [this message]
2020-07-29 19:59 ` Brendan Higgins
2020-08-03 8:57 ` Andy Shevchenko
2020-07-29 20:16 ` Vitor Massaru Iha
2020-08-03 6:16 ` kernel test robot
2020-08-03 7:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729191948.GZ3703480@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=brendanhiggins@google.com \
--cc=fkostenzer@live.at \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=skhan@linuxfoundation.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).