From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B54EC4363D for ; Wed, 30 Sep 2020 23:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 633082076B for ; Wed, 30 Sep 2020 23:25:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nOvXiMAl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732229AbgI3XZn (ORCPT ); Wed, 30 Sep 2020 19:25:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730763AbgI3XZn (ORCPT ); Wed, 30 Sep 2020 19:25:43 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEC2BC061755 for ; Wed, 30 Sep 2020 16:25:42 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id 197so2296319pge.8 for ; Wed, 30 Sep 2020 16:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hlKJ+FfSVyIeAzaG/EkGK7Un9Pk3Wxr576MJ7E0I3IY=; b=nOvXiMAlZRb1yYmHnykzlJkQbKnxwV9bDYf+wWvHWfHj0HDv1wrV0dIHsJcaRF6xB9 6IvRQ3xg0G1NMN2hzZF8NzoFqBkCXbYsA1JlYu/FAqyq4SGaLPL3KNfQ7zZK2f6xAkwC oVAqbFCmOv7bXjgEFR1YXgLTsGqgSRFnNEYuA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hlKJ+FfSVyIeAzaG/EkGK7Un9Pk3Wxr576MJ7E0I3IY=; b=glw7XTDIBw0XVnpdyDgiV4PhE9yNp9m6pxBwKtUkYF042NU+e5KY1AotF7K/IC+Z/Y +02NB7Z18zdlg+axOyhRifFVQ+nF7Y/ESuZI5uuNhbLXD7sTIEyHnYkYXEoL0UyzUsV+ 5LgaQjeDcb0grT3tG8cNHQBkfurjuNdk3+556D61mVkE3jMv6vozpi32U2EJHuD0dhtI F+2B4Zb+6eJTlXCAB9QuANaQ4CmB/VWD3yCPsdwbsAWKa+pMaLyfTcgdBOFgvaV1cCz2 6lmLltQKSlKxyE/5KBW0IlqDbWgNSywslReDomklutAJLYPVUOVyrPDafIEVT+K/jW3e /pjw== X-Gm-Message-State: AOAM532OfsOd/Y6IeiDM1SWPlFxw2UdeT5JJ4ZAcAGJGpV9yk5u8Tw3e J8MgwLRVzbY8Wt5A57T5qRHDMQ== X-Google-Smtp-Source: ABdhPJz4E75cT8NJjYPlBQdG+MQ2UTB47oeQ8Y0P9yaLMPFMg8LU1mJHM799gXVf6QspTSWIIxJs3g== X-Received: by 2002:a63:c04d:: with SMTP id z13mr3928899pgi.215.1601508342469; Wed, 30 Sep 2020 16:25:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id fz22sm3262561pjb.46.2020.09.30.16.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 16:25:41 -0700 (PDT) Date: Wed, 30 Sep 2020 16:25:40 -0700 From: Kees Cook To: Naresh Kamboju Cc: Shuah Khan , Hangbin Liu , Jonathan Corbet , linux-doc@vger.kernel.org, Tim.Bird@sony.com, lkft-triage@lists.linaro.org, Anders Roxell , Justin Cook , Linux-Next Mailing List , open list , "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH v2 0/3] Extract run_kselftest.sh and generate stand-alone test list Message-ID: <202009301624.5698D652C4@keescook> References: <20200928202650.2530280-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Sep 30, 2020 at 09:47:49PM +0530, Naresh Kamboju wrote: > On Tue, 29 Sep 2020 at 01:56, Kees Cook wrote: > > > > v2: > > - update documentation > > - include SPDX line in extracted script > > v1: https://lore.kernel.org/linux-kselftest/20200925234527.1885234-1-keescook@chromium.org/ > > > > > > Hi! > > > > I really like Hangbin Liu's intent[1] but I think we need to be a little > > more clean about the implementation. This extracts run_kselftest.sh from > > the Makefile so it can actually be changed without embeds, etc. Instead, > > generate the test list into a text file. Everything gets much simpler. > > :) > > > > And in patch 2, I add back Hangbin Liu's new options (with some extra > > added) with knowledge of "collections" (i.e. Makefile TARGETS) and > > subtests. This should work really well with LAVA too, which needs to > > manipulate the lists of tests being run. > > > > Thoughts? > > I have tested this patch set on LAVA with full run and it went well. Thank you! You can include this as a tag too, so a "b4 am" will pick it up: Tested-by: Naresh Kamboju -Kees > > > > > -Kees > > > > [1] https://lore.kernel.org/lkml/20200914022227.437143-1-liuhangbin@gmail.com/ > > > > Kees Cook (3): > > selftests: Extract run_kselftest.sh and generate stand-alone test list > > selftests/run_kselftest.sh: Make each test individually selectable > > doc: dev-tools: kselftest.rst: Update examples and paths > > > > Documentation/dev-tools/kselftest.rst | 35 +++++---- > > tools/testing/selftests/Makefile | 26 ++----- > > tools/testing/selftests/lib.mk | 5 +- > > tools/testing/selftests/run_kselftest.sh | 93 ++++++++++++++++++++++++ > > 4 files changed, 124 insertions(+), 35 deletions(-) > > create mode 100755 tools/testing/selftests/run_kselftest.sh > > > > -- > > 2.25.1 > > > > - Naresh -- Kees Cook