From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A716C5517A for ; Thu, 22 Oct 2020 19:11:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E23D52465A for ; Thu, 22 Oct 2020 19:11:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S369886AbgJVTLs (ORCPT ); Thu, 22 Oct 2020 15:11:48 -0400 Received: from mga11.intel.com ([192.55.52.93]:21303 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S369878AbgJVTLs (ORCPT ); Thu, 22 Oct 2020 15:11:48 -0400 IronPort-SDR: ud4vSNKi5MoIzhJ1ZsXvFVfcaXTnTrHIo4UjN8QmwJR42rpWliA7VR01cFSu45gSVDGdQshOpV Pmh3kvPsFrbA== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="164088917" X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="164088917" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 12:11:47 -0700 IronPort-SDR: W+vNVUsNCq6wWKJXfRd0xUT9Q8ThOm1PMG3sCwg4e7jKbl9prIsyK2iYgJdOBjiYMLMMSlcRCJ 5mfOotX5O6kA== X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="534088023" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 12:11:45 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kVg12-00DVhv-Hg; Thu, 22 Oct 2020 22:12:48 +0300 Date: Thu, 22 Oct 2020 22:12:48 +0300 From: Andy Shevchenko To: Daniel Latypov Cc: David Gow , Brendan Higgins , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Subject: Re: [PATCH] lib: add basic KUnit test for lib/math Message-ID: <20201022191248.GP4077@smile.fi.intel.com> References: <20201019224556.3536790-1-dlatypov@google.com> <20201022150648.GH4077@smile.fi.intel.com> <20201022191038.GO4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201022191038.GO4077@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Oct 22, 2020 at 10:10:38PM +0300, Andy Shevchenko wrote: > On Thu, Oct 22, 2020 at 09:26:45AM -0700, Daniel Latypov wrote: > > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko > > wrote: > > > On Wed, Oct 21, 2020 at 10:47:50AM -0700, Daniel Latypov wrote: ... > > > Summarize this, please create usable documentation first. > > > > Sounds good. > > I'm generally wary people not reading the docs, and of documentation > > examples becoming bitrotted faster than actual code. > > But so far KUnit seems to be doing relatively well on both fronts. > > Dunno. As I told, I have created first unit test based on documentation (okay, > I looked at the code, but you may read this as ratio was 90% doc / 10% existing > code). Side note: some cases are not described in doc and produced "interesting" results that I have to look a lot into KUnit Python wrapper to fix bugs in it. You may find my patches in the KUnit mailing list. -- With Best Regards, Andy Shevchenko