From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB07C55178 for ; Fri, 23 Oct 2020 09:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3038D22253 for ; Fri, 23 Oct 2020 09:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S461026AbgJWJB0 (ORCPT ); Fri, 23 Oct 2020 05:01:26 -0400 Received: from mga07.intel.com ([134.134.136.100]:23238 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S461025AbgJWJB0 (ORCPT ); Fri, 23 Oct 2020 05:01:26 -0400 IronPort-SDR: CIFz7M4xkK2hJSSYccB1wWaT/6Vd7/MZ7j7RwPVrCaqxfZGaTTDFqU4WC5Kt7+yrN1fDFSJ/JX 1BoBxNEyNiFw== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="231840766" X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="231840766" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 02:01:21 -0700 IronPort-SDR: i3SWmya743zVVazoHQs8wNWqqa8Qz6PMQjBNo1vAo4isqGXlOIatvdRXSjj0Sa+fjknEcLWddH eS9BjPGET3Bw== X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="467003027" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 02:01:19 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kVsxo-00Dxdu-Ib; Fri, 23 Oct 2020 12:02:20 +0300 Date: Fri, 23 Oct 2020 12:02:20 +0300 From: Andy Shevchenko To: Brendan Higgins Cc: Daniel Latypov , David Gow , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , Shuah Khan Subject: Re: [PATCH] lib: add basic KUnit test for lib/math Message-ID: <20201023090220.GU4077@smile.fi.intel.com> References: <20201019224556.3536790-1-dlatypov@google.com> <20201022150648.GH4077@smile.fi.intel.com> <20201022190526.GN4077@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Thu, Oct 22, 2020 at 02:21:40PM -0700, Brendan Higgins wrote: > On Thu, Oct 22, 2020 at 12:04 PM Andy Shevchenko > wrote: > > On Thu, Oct 22, 2020 at 11:53:50AM -0700, Brendan Higgins wrote: > > > On Thu, Oct 22, 2020 at 8:06 AM Andy Shevchenko > > > wrote: ... > > Why do we have docs in the first place? > > For test cases I think it's a crucial part, because tests many time are written > > by newbies, who would like to understand all under-the-hood stuff. You imply > > Good point. Yeah, we don't really have any documentation that explains > the internals at all. I agree: we need to fix that. > > > that they need to drop themselves into the code directly. It's very harsh to > > begin with Linux kernel development, really. > > No, I was not trying to imply that everyone should just jump in the > code and ignore the docs. I was just trying to point out that some > people - myself included - rather see code than docs. Clearly some > people prefer docs over code as well. Thus, I was trying to argue that > both are appropriate. > > Nevertheless, based on the other comments you sent, I don't think > that's what we are talking about: sounds like you just want us to > improve the docs first to make sure we do it. That's fine with me. Right. What confused me is that test cases for math were pushed as a good example how to create a test case, but at the same time docs left untouched. -- With Best Regards, Andy Shevchenko