From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kselftest@vger.kernel.org,
Brendan Higgins <brendanhiggins@google.com>,
kunit-dev@googlegroups.com,
Shuah Khan <skhan@linuxfoundation.org>,
Vitor Massaru Iha <vitor@massaru.org>
Cc: Mark Brown <broonie@kernel.org>, David Gow <davidgow@google.com>
Subject: Re: [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests
Date: Fri, 30 Oct 2020 21:50:52 +0200 [thread overview]
Message-ID: <20201030195052.GV4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201016110836.52613-1-andriy.shevchenko@linux.intel.com>
On Fri, Oct 16, 2020 at 02:08:34PM +0300, Andy Shevchenko wrote:
> Follow new file name convention for the KUnit tests.
> Since we have lib/*test*.c in a few variations,
> use 'kunit' suffix to distinguish usual test cases
> with KUnit-based ones.
Can we get this applied?
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: David Gow <davidgow@google.com>
> ---
> v3: added Rb (David), expanded Cc (Mark)
> MAINTAINERS | 2 +-
> lib/Makefile | 2 +-
> lib/{list-test.c => list_kunit.c} | 0
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename lib/{list-test.c => list_kunit.c} (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4538378de6f5..20facbca9388 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10188,7 +10188,7 @@ M: David Gow <davidgow@google.com>
> L: linux-kselftest@vger.kernel.org
> L: kunit-dev@googlegroups.com
> S: Maintained
> -F: lib/list-test.c
> +F: lib/list_kunit.c
>
> LIVE PATCHING
> M: Josh Poimboeuf <jpoimboe@redhat.com>
> diff --git a/lib/Makefile b/lib/Makefile
> index 5ca03ba6ee45..1a5e6a6ebe8d 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -350,6 +350,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/
>
> # KUnit tests
> obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
> -obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
> +obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o
> obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
> obj-$(CONFIG_BITS_TEST) += test_bits.o
> diff --git a/lib/list-test.c b/lib/list_kunit.c
> similarity index 100%
> rename from lib/list-test.c
> rename to lib/list_kunit.c
> --
> 2.28.0
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-10-30 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 11:08 [PATCH v3 1/3] lib/list_kunit: Follow new file name convention for KUnit tests Andy Shevchenko
2020-10-16 11:08 ` [PATCH v3 2/3] lib/linear_ranges_kunit: " Andy Shevchenko
2020-10-16 16:07 ` Mark Brown
2020-10-16 11:08 ` [PATCH v3 3/3] lib/bits_kunit: " Andy Shevchenko
2020-10-20 20:55 ` Brendan Higgins
2020-10-20 20:55 ` [PATCH v3 1/3] lib/list_kunit: " Brendan Higgins
2020-10-30 19:50 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030195052.GV4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).