From: kernel test robot <lkp@intel.com>
To: Daniel Latypov <dlatypov@google.com>, andriy.shevchenko@linux.intel.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
brendanhiggins@google.com, davidgow@google.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
skhan@linuxfoundation.org, Daniel Latypov <dlatypov@google.com>
Subject: Re: [PATCH] lib: add basic KUnit test for lib/math
Date: Tue, 3 Nov 2020 09:32:15 +0800 [thread overview]
Message-ID: <202011030909.8ogASyi6-lkp@intel.com> (raw)
In-Reply-To: <20201019224556.3536790-1-dlatypov@google.com>
[-- Attachment #1: Type: text/plain, Size: 2557 bytes --]
Hi Daniel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 7cf726a59435301046250c42131554d9ccc566b8]
url: https://github.com/0day-ci/linux/commits/Daniel-Latypov/lib-add-basic-KUnit-test-for-lib-math/20201020-064737
base: 7cf726a59435301046250c42131554d9ccc566b8
config: mips-randconfig-r032-20201030 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project fa5a13276764a2657b3571fa3c57b07ee5d2d661)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://github.com/0day-ci/linux/commit/e268c8ae297dc311e5deb6b25daad9a2f88309ba
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Latypov/lib-add-basic-KUnit-test-for-lib-math/20201020-064737
git checkout e268c8ae297dc311e5deb6b25daad9a2f88309ba
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> lib/math/math_test.c:137:13: warning: shift count >= width of type [-Wshift-count-overflow]
.a = 1UL >> 32,
^ ~~
1 warning generated.
vim +137 lib/math/math_test.c
109
110 static void int_sqrt_test(struct kunit *test)
111 {
112 const char *message_fmt = "sqrt(%lu)";
113 int i;
114
115 struct test_case test_cases[] = {
116 {
117 .a = 0,
118 .result = 0,
119 },
120 {
121 .a = 1,
122 .result = 1,
123 },
124 {
125 .a = 4,
126 .result = 2,
127 },
128 {
129 .a = 5,
130 .result = 2,
131 },
132 {
133 .a = 8,
134 .result = 2,
135 },
136 {
> 137 .a = 1UL >> 32,
138 .result = 1UL >> 16,
139 },
140 };
141
142 for (i = 0; i < ARRAY_SIZE(test_cases); ++i) {
143 KUNIT_EXPECT_EQ_MSG(test, int_sqrt(test_cases[i].a),
144 test_cases[i].result, message_fmt,
145 test_cases[i].a);
146 }
147 }
148
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27135 bytes --]
prev parent reply other threads:[~2020-11-03 1:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 22:45 [PATCH] lib: add basic KUnit test for lib/math Daniel Latypov
2020-10-20 0:45 ` kernel test robot
2020-10-20 8:09 ` Andy Shevchenko
2020-10-20 16:13 ` Daniel Latypov
2020-10-21 3:40 ` David Gow
2020-10-21 17:47 ` Daniel Latypov
2020-10-22 15:06 ` Andy Shevchenko
2020-10-22 16:26 ` Daniel Latypov
2020-10-22 18:51 ` Brendan Higgins
2020-10-22 19:10 ` Andy Shevchenko
2020-10-22 19:12 ` Andy Shevchenko
2020-10-22 18:53 ` Brendan Higgins
2020-10-22 19:05 ` Andy Shevchenko
2020-10-22 21:21 ` Brendan Higgins
2020-10-23 9:02 ` Andy Shevchenko
2020-11-02 14:51 ` kernel test robot
2020-11-03 1:32 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011030909.8ogASyi6-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).