From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kees Cook <keescook@chromium.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
rafael@kernel.org, Will Deacon <will@kernel.org>,
linux-kselftest@vger.kernel.org, joel@joelfernandes.org,
rric@kernel.org, shuah@kernel.org, devel@driverdev.osuosl.org,
minyard@acm.org, corbet@lwn.net, surenb@google.com,
linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org,
lenb@kernel.org, tkjos@android.com, arnd@arndb.de, bp@alien8.de,
Shuah Khan <skhan@linuxfoundation.org>,
openipmi-developer@lists.sourceforge.net, mchehab@kernel.org,
maco@android.com, christian@brauner.io,
linux-edac@vger.kernel.org, tony.luck@intel.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
arve@android.com, james.morse@arm.com, hridya@google.com,
johannes@sipsolutions.net
Subject: Re: [PATCH v3 00/11] Introduce Simple atomic counters
Date: Tue, 10 Nov 2020 21:49:03 +0300 [thread overview]
Message-ID: <20201110184903.GG29398@kadam> (raw)
In-Reply-To: <202010161541.6DD2D1E@keescook>
On Fri, Oct 16, 2020 at 03:51:25PM -0700, Kees Cook wrote:
> On Fri, Oct 16, 2020 at 12:53:13PM +0200, Peter Zijlstra wrote:
> > That's like saying: "I'm too lazy to track what I've looked at already".
> > You're basically proposing to graffiti "Kees was here -- 16/10/2020" all
> > over the kernel. Just so you can see where you still need to go.
> >
> > It says the code was (assuming your audit was correct) good at that
> > date, but has no guarantees for any moment after that.
>
> That kind of bit-rot marking is exactly what I would like to avoid: just
> putting a comment in is pointless. Making the expectations of the usage
> become _enforced_ is the goal. And having it enforced by the _compiler_
> is key. Just adding a meaningless attribute that a static checker
> will notice some time and hope people fix them doesn't scale either
> (just look at how many sparse warnings there are).
Most Sparse warnings are false positives. People do actually fix the
ones which matter.
I think this patchset could be useful. I'm working on a refcounting
check for Smatch. I want to warn about when we forget to drop a
reference on an error path. Right now I just assume that anything with
"error", "drop" or "->stats->" in the name is just a counter.
regards,
dan carpenter
next prev parent reply other threads:[~2020-11-10 18:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 15:55 [PATCH v3 00/11] Introduce Simple atomic counters Shuah Khan
2020-10-09 15:55 ` [PATCH v3 02/11] selftests:lib:test_counters: add new test for counters Shuah Khan
2020-10-09 18:02 ` Kees Cook
2020-10-09 18:03 ` [PATCH v3 00/11] Introduce Simple atomic counters Kees Cook
2020-10-09 19:02 ` Shuah Khan
2020-10-09 19:37 ` Peter Zijlstra
2020-10-09 20:45 ` Kees Cook
2020-10-10 11:09 ` Peter Zijlstra
2020-10-14 2:12 ` Shuah Khan
2020-10-14 9:17 ` Peter Zijlstra
2020-10-14 23:31 ` Kees Cook
2020-10-16 10:53 ` Peter Zijlstra
2020-10-16 22:51 ` Kees Cook
2020-11-10 18:49 ` Dan Carpenter [this message]
2020-10-16 21:56 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110184903.GG29398@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=bp@alien8.de \
--cc=christian@brauner.io \
--cc=corbet@lwn.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=james.morse@arm.com \
--cc=joel@joelfernandes.org \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maco@android.com \
--cc=mchehab@kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rric@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=tony.luck@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).