archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] kunit: tool: remove unnecessary "annotations" import
@ 2021-06-29  0:39 Daniel Latypov
  0 siblings, 0 replies; only message in thread
From: Daniel Latypov @ 2021-06-29  0:39 UTC (permalink / raw)
  To: brendanhiggins, davidgow
  Cc: linux-kernel, kunit-dev, linux-kselftest, skhan, Daniel Latypov

The import was working around the fact "tuple[T]" was used instead of

Convert it to use typing.Tuple to be consistent with how the rest of the
code is annotated.

Signed-off-by: Daniel Latypov <>
Reviewed-by: David Gow <>
Reviewed-by: Brendan Higgins <>
Tested-by: Brendan Higgins <>
v1 -> v2: fix typos in commit message.
 tools/testing/kunit/ | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/testing/kunit/ b/tools/testing/kunit/
index 90bc007f1f93..2c6f916ccbaf 100644
--- a/tools/testing/kunit/
+++ b/tools/testing/kunit/
@@ -6,15 +6,13 @@
 # Author: Felix Guo <>
 # Author: Brendan Higgins <>
-from __future__ import annotations
 import importlib.util
 import logging
 import subprocess
 import os
 import shutil
 import signal
-from typing import Iterator
-from typing import Optional
+from typing import Iterator, Optional, Tuple
 from contextlib import ExitStack
@@ -208,7 +206,7 @@ def get_source_tree_ops(arch: str, cross_compile: Optional[str]) -> LinuxSourceT
 		raise ConfigError(arch + ' is not a valid arch')
 def get_source_tree_ops_from_qemu_config(config_path: str,
-					 cross_compile: Optional[str]) -> tuple[
+					 cross_compile: Optional[str]) -> Tuple[
 							 str, LinuxSourceTreeOperations]:
 	# The module name/path has very little to do with where the actual file
 	# exists (I learned this through experimentation and could not find it

base-commit: 1d71307a6f94df3750f8f884545a769e227172fe

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-06-29  0:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29  0:39 [PATCH v2] kunit: tool: remove unnecessary "annotations" import Daniel Latypov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).