archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <>
To: Trent Piepho <>,
	Colin Ian King <>,
	Andy Shevchenko <>,
	Andrew Morton <>,
	Brendan Higgins <>
	Geert Uytterhoeven <>
Subject: [PATCH 2/2] math: RATIONAL_KUNIT_TEST should depend on RATIONAL instead of selecting it
Date: Tue,  6 Jul 2021 12:09:45 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

RATIONAL_KUNIT_TEST selects RATIONAL, thus enabling an optional feature
the user may not want to have enabled.  Fix this by making the test
depend on RATIONAL instead.

Fixes: b6c75c4afceb8bc0 ("lib/math/rational: add Kunit test cases")
Signed-off-by: Geert Uytterhoeven <>
The RATIONAL config symbol is not visible, which means that this test
can only be enabled when there is a user of RATIONAL.

  - New.
 lib/Kconfig.debug | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 8acc01d7d816518c..f368764ff4a91f4a 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2449,8 +2449,7 @@ config SLUB_KUNIT_TEST
 	tristate "KUnit test for rational.c" if !KUNIT_ALL_TESTS
-	depends on KUNIT
-	select RATIONAL
+	depends on KUNIT && RATIONAL
 	  This builds the rational math unit test.

      parent reply	other threads:[~2021-07-06 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 10:09 [PATCH 0/2] math: RATIONAL and RATIONAL_KUNIT_TEST improvements Geert Uytterhoeven
2021-07-06 10:09 ` [PATCH 1/2] math: Make RATIONAL tristate Geert Uytterhoeven
2021-07-06 10:31   ` Andy Shevchenko
2021-07-06 10:09 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).