From: "George G. Davis" <george_davis@mentor.com>
To: Shuah Khan <shuah@kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Eugeniu Rosca <erosca@de.adit-jv.com>,
"George G. Davis" <davis.george@siemens.com>
Subject: Re: [RFC][PATCH] selftests/vm/transhuge-stress: fix ram size thinko
Date: Tue, 28 Sep 2021 13:58:54 -0400 [thread overview]
Message-ID: <20210928175854.GA7313@mam-gdavis-dt> (raw)
In-Reply-To: <20210825135843.29052-1-george_davis@mentor.com>
On Wed, Aug 25, 2021 at 09:58:43AM -0400, George G. Davis wrote:
> From: "George G. Davis" <davis.george@siemens.com>
>
> When executing transhuge-stress with an argument to specify the virtual
> memory size for testing, the ram size is reported as 0, e.g.
>
> transhuge-stress 384
> thp-mmap: allocate 192 transhuge pages, using 384 MiB virtual memory and 0 MiB of ram
> thp-mmap: 0.184 s/loop, 0.957 ms/page, 2090.265 MiB/s 192 succeed, 0 failed
>
> This appears to be due to a thinko in commit 0085d61fe05e
> ("selftests/vm/transhuge-stress: stress test for memory compaction"),
> where, at a guess, the intent was to base "xyz MiB of ram" on `ram`
> size. Here are results after using `ram` size:
>
> thp-mmap: allocate 192 transhuge pages, using 384 MiB virtual memory and 14 MiB of ram
>
> Fixes: 0085d61fe05e ("selftests/vm/transhuge-stress: stress test for memory compaction")
> Signed-off-by: George G. Davis <davis.george@siemens.com>
> ---
> tools/testing/selftests/vm/transhuge-stress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/vm/transhuge-stress.c b/tools/testing/selftests/vm/transhuge-stress.c
> index fd7f1b4a96f9..5e4c036f6ad3 100644
> --- a/tools/testing/selftests/vm/transhuge-stress.c
> +++ b/tools/testing/selftests/vm/transhuge-stress.c
> @@ -79,7 +79,7 @@ int main(int argc, char **argv)
>
> warnx("allocate %zd transhuge pages, using %zd MiB virtual memory"
> " and %zd MiB of ram", len >> HPAGE_SHIFT, len >> 20,
> - len >> (20 + HPAGE_SHIFT - PAGE_SHIFT - 1));
> + ram >> (20 + HPAGE_SHIFT - PAGE_SHIFT - 1));
Ping, any comments on this?
For the record, as noted, the value reported for "ram size" appears to
use the wrong variable, `len`, where `ram` should be used instead.
>
> pagemap_fd = open("/proc/self/pagemap", O_RDONLY);
> if (pagemap_fd < 0)
> --
> 2.17.1
>
--
Regards,
George
next prev parent reply other threads:[~2021-09-28 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 13:58 [RFC][PATCH] selftests/vm/transhuge-stress: fix ram size thinko George G. Davis
2021-09-28 17:58 ` George G. Davis [this message]
2021-10-15 15:38 ` Shuah Khan
2021-10-15 19:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928175854.GA7313@mam-gdavis-dt \
--to=george_davis@mentor.com \
--cc=davis.george@siemens.com \
--cc=erosca@de.adit-jv.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).