From: SeongJae Park <sj@kernel.org>
To: akpm@linux-foundation.org
Cc: shuah@kernel.org, brendanhiggins@google.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
SeongJae Park <sj@kernel.org>
Subject: [PATCH 02/11] mm/damon/dbgfs: Remove an unnecessary error message
Date: Wed, 1 Dec 2021 15:04:31 +0000 [thread overview]
Message-ID: <20211201150440.1088-3-sj@kernel.org> (raw)
In-Reply-To: <20211201150440.1088-1-sj@kernel.org>
When wrong scheme action is requested via the debugfs interface, DAMON
prints an error message. Because the function returns error code, this
is not really needed. Because the code path is triggered by the user
specified input, this can result in kernel log mistakenly being messy.
To avoid the case, this commit removes the message.
Fixes: af122dd8f3c0 ("mm/damon/dbgfs: support DAMON-based Operation Schemes")
Signed-off-by: SeongJae Park <sj@kernel.org>
---
mm/damon/dbgfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c
index 4bf4204444ab..5b628990ae6e 100644
--- a/mm/damon/dbgfs.c
+++ b/mm/damon/dbgfs.c
@@ -210,10 +210,8 @@ static struct damos **str_to_schemes(const char *str, ssize_t len,
&wmarks.low, &parsed);
if (ret != 18)
break;
- if (!damos_action_valid(action)) {
- pr_err("wrong action %d\n", action);
+ if (!damos_action_valid(action))
goto fail;
- }
if (min_sz > max_sz || min_nr_a > max_nr_a || min_age > max_age)
goto fail;
--
2.17.1
next prev parent reply other threads:[~2021-12-01 15:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 15:04 [PATCH 00/11] mm/damon: Trivial fixups and improvements SeongJae Park
2021-12-01 15:04 ` [PATCH 01/11] mm/damon/core: Use better timer mechanisms selection threshold SeongJae Park
2021-12-01 15:04 ` SeongJae Park [this message]
2021-12-08 6:29 ` [PATCH 02/11] mm/damon/dbgfs: Remove an unnecessary error message Xin Hao
2021-12-08 12:49 ` SeongJae Park
2021-12-08 15:13 ` Xin Hao
2021-12-08 16:48 ` SeongJae Park
2021-12-01 15:04 ` [PATCH 03/11] mm/damon/core: Remove unnecessary error messages SeongJae Park
2021-12-01 15:04 ` [PATCH 04/11] mm/damon/vaddr: Remove an unnecessary warning message SeongJae Park
2021-12-03 3:01 ` Muchun Song
2021-12-03 20:44 ` Andrew Morton
2021-12-04 2:37 ` Muchun Song
2021-12-01 15:04 ` [PATCH 05/11] mm/damon/vaddr-test: Split a test function having >1024 bytes frame size SeongJae Park
2021-12-01 15:04 ` [PATCH 06/11] mm/damon/vaddr-test: Remove unnecessary variables SeongJae Park
2021-12-01 15:04 ` [PATCH 07/11] selftests/damon: Skip test if DAMON is running SeongJae Park
2021-12-01 15:04 ` [PATCH 08/11] selftests/damon: Test DAMON enabling with empty target_ids case SeongJae Park
2021-12-01 15:04 ` [PATCH 09/11] selftests/damon: Test wrong DAMOS condition ranges input SeongJae Park
2021-12-01 15:04 ` [PATCH 10/11] selftests/damon: Test debugfs file reads/writes with huge count SeongJae Park
2021-12-01 15:04 ` [PATCH 11/11] selftests/damon: Split test cases SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201150440.1088-3-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brendanhiggins@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).